RDBC-1028: quote SuggestToken alias containing spaces in generated RQL

SuggestToken.write_to() emitted the alias unquoted, so multi-word display names (e.g. 'Customized name with spaces') broke the RQL parser on the server.
Fix: pass the alias through QueryFieldUtil.escape_if_necessary(), matching the C# client's use of QueryFieldUtil.EscapeIfNecessary().

Regression test: test_suggest_alias_escaping.py verifies that a suggest alias containing spaces is wrapped in single quotes in the generated RQL.

Author: redknightlois

ravendb/documents/session/tokens/query_tokens/definitions.py

@@ -22,7 +22,7 @@
 from ravendb.documents.session.tokens.query_tokens.query_token import QueryToken
 from ravendb.documents.session.utils.document_query import DocumentQueryHelper
 from ravendb.primitives.constants import VectorSearch
-from ravendb.tools.utils import Utils
+from ravendb.tools.utils import Utils, QueryFieldUtil
 
 
 class CompareExchangeValueIncludesToken(QueryToken):
@@ -992,7 +992,7 @@ def write_to(self, writer: List[str]) -> None:
             return
 
         writer.append(" as ")
-        writer.append(self.__alias)
+        writer.append(QueryFieldUtil.escape_if_necessary(self.__alias))
 
 
 class VectorSearchToken(WhereToken):

ravendb/tests/session_tests/test_suggest_alias_escaping.py

@@ -0,0 +1,65 @@
+"""
+Suggestions: display names containing spaces are quoted in the generated RQL.
+
+C# reference: SlowTests/Issues/RavenDB_20673.cs
+  CustomizeDisplayNameWithSpaces, CustomizeDisplayNameWithOutSpaces
+"""
+
+from ravendb.documents.queries.suggestions import SuggestionBuilder
+from ravendb.tests.test_base import TestBase
+
+
+class User:
+    def __init__(self, name: str = None):
+        self.name = name
+
+
+class TestRavenDB20673(TestBase):
+    def setUp(self):
+        super().setUp()
+
+    def _setup_data(self):
+        with self.store.open_session() as session:
+            session.store(User(name="dan"), "users/1")
+            session.store(User(name="daniel"), "users/2")
+            session.store(User(name="danielle"), "users/3")
+            session.save_changes()
+
+        self.wait_for_indexing(self.store)
+
+    def test_suggestion_display_name_without_spaces(self):
+        """Display names without spaces must work — baseline sanity check."""
+        self._setup_data()
+
+        with self.store.open_session() as session:
+
+            def build(b: SuggestionBuilder):
+                b.by_field("name", "daniele").with_display_name("CustomizedName")
+
+            suggestion_query = session.query(object_type=User).suggest_using(build)
+            rql = suggestion_query.__str__()
+            self.assertIn("CustomizedName", rql)
+
+            results = suggestion_query.execute()
+            self.assertIn("CustomizedName", results)
+            self.assertEqual(2, len(results["CustomizedName"].suggestions))
+            self.assertIn("danielle", results["CustomizedName"].suggestions)
+
+    def test_suggestion_display_name_with_spaces(self):
+        """Display names containing spaces must be quoted in the RQL."""
+        self._setup_data()
+
+        with self.store.open_session() as session:
+
+            def build(b: SuggestionBuilder):
+                b.by_field("name", "daniele").with_display_name("Customized name with spaces")
+
+            suggestion_query = session.query(object_type=User).suggest_using(build)
+            rql = suggestion_query.__str__()
+            # escape_if_necessary wraps aliases containing spaces in single quotes
+            self.assertIn("'Customized name with spaces'", rql)
+
+            results = suggestion_query.execute()
+            self.assertIn("Customized name with spaces", results)
+            self.assertEqual(2, len(results["Customized name with spaces"].suggestions))
+            self.assertIn("danielle", results["Customized name with spaces"].suggestions)