Skip to content

Commit 1062edf

Browse files
committed
Remove element-wise comparison in tests
1 parent 8e5ff5e commit 1062edf

2 files changed

Lines changed: 2 additions & 7 deletions

File tree

core-api/src/test/java/com/optimizely/ab/config/parser/GsonConfigParserTest.java

Lines changed: 1 addition & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -417,9 +417,7 @@ public void testFromJson() {
417417
Map<String, Object> map = null;
418418
try {
419419
map = parser.fromJson(json, Map.class);
420-
for (String key : map.keySet()) {
421-
assertEquals(expectedMap.get(key), map.get(key));
422-
}
420+
assertEquals(expectedMap, map);
423421
} catch (JsonParseException e) {
424422
fail("Parse to map failed: " + e.getMessage());
425423
}

core-api/src/test/java/com/optimizely/ab/optimizelyjson/OptimizelyJSONWithGsonParserTest.java

Lines changed: 1 addition & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -64,10 +64,7 @@ public void testIntegerProcessing() throws JsonParseException {
6464
m1.put("k3", m2);
6565

6666
OptimizelyJSON oj1 = new OptimizelyJSON(json, getParser());
67-
Map<String, Object> ojMap = oj1.toMap();
68-
for (String key : m1.keySet()) {
69-
assertEquals(m1.get(key), ojMap.get(key));
70-
}
67+
assertEquals(oj1.toMap(), m1);
7168
}
7269

7370
@Test

0 commit comments

Comments
 (0)