Context
The Makefile under component/Makefile is always calling print-rc-version which results in naming the component rc1 always. Even though it's just a simple release.
The logic needs to be updated like it is in release.yaml:
- name: Set release version
run: |
if ${{ inputs.release_candidate }}; then
echo "RELEASE_VERSION=$(go run $GITHUB_WORKSPACE/pkg/version/generate/release_generate.go print-rc-version)" >> $GITHUB_ENV
else
echo "RELEASE_VERSION=$(go run $GITHUB_WORKSPACE/pkg/version/generate/release_generate.go print-version)" >> $GITHUB_ENV
fi
instead of using $(CANDIDATE) which is no longer a supported functionality.
Version
v0.26.1
To Reproduce
Steps to reproduce the behavior:
Actual behavior
A clear and concise description of what is happening.
Expected behavior
A clear and concise description of what you expected to happen.
Screenshots (optional)
If applicable, add screenshots to help explain your problem.
Environment
Additional Comments
Any observation, gut feeling or other information you think help the community to troubleshoot the problem?
Context
The Makefile under
component/Makefileis always callingprint-rc-versionwhich results in naming the component rc1 always. Even though it's just a simple release.The logic needs to be updated like it is in release.yaml:
instead of using
$(CANDIDATE)which is no longer a supported functionality.Version
v0.26.1
To Reproduce
Steps to reproduce the behavior:
Actual behavior
A clear and concise description of what is happening.
Expected behavior
A clear and concise description of what you expected to happen.
Screenshots (optional)
If applicable, add screenshots to help explain your problem.
Environment
Additional Comments
Any observation, gut feeling or other information you think help the community to troubleshoot the problem?