Skip to content

Commit d55d5fb

Browse files
committed
src: clean up experimental flag variables
- `fetch` is no longer disable by a CLI flag - `node:sqlite` requires SQLite, obviously Signed-off-by: Antoine du Hamel <duhamelantoine1995@gmail.com>
1 parent 3f52482 commit d55d5fb

File tree

4 files changed

+5
-9
lines changed

4 files changed

+5
-9
lines changed

src/api/environment.cc

Lines changed: 2 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -267,13 +267,9 @@ void SetIsolateMiscHandlers(v8::Isolate* isolate, const IsolateSettings& s) {
267267
isolate->SetModifyCodeGenerationFromStringsCallback(
268268
modify_code_generation_from_strings_callback);
269269

270-
Mutex::ScopedLock lock(node::per_process::cli_options_mutex);
271-
if (per_process::cli_options->get_per_isolate_options()
272-
->get_per_env_options()
273-
->experimental_fetch) {
274-
isolate->SetWasmStreamingCallback(wasm_web_api::StartStreamingCompilation);
275-
}
270+
isolate->SetWasmStreamingCallback(wasm_web_api::StartStreamingCompilation);
276271

272+
Mutex::ScopedLock lock(node::per_process::cli_options_mutex);
277273
if (per_process::cli_options->get_per_isolate_options()
278274
->experimental_shadow_realm) {
279275
isolate->SetHostCreateShadowRealmContextCallback(

src/node_options.cc

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -605,7 +605,7 @@ EnvironmentOptionsParser::EnvironmentOptionsParser() {
605605
"experimental node:sqlite module",
606606
&EnvironmentOptions::experimental_sqlite,
607607
kAllowedInEnvvar,
608-
true);
608+
HAVE_SQLITE);
609609
AddOption("--experimental-stream-iter",
610610
"experimental iterable streams API (node:stream/iter)",
611611
&EnvironmentOptions::experimental_stream_iter,

src/node_options.h

Lines changed: 1 addition & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -124,10 +124,9 @@ class EnvironmentOptions : public Options {
124124
bool enable_source_maps = false;
125125
bool experimental_addon_modules = false;
126126
bool experimental_eventsource = false;
127-
bool experimental_fetch = true;
128127
bool experimental_ffi = false;
129128
bool experimental_websocket = true;
130-
bool experimental_sqlite = true;
129+
bool experimental_sqlite = HAVE_SQLITE;
131130
bool experimental_stream_iter = false;
132131
bool webstorage = HAVE_SQLITE;
133132
bool experimental_quic = false;

test/parallel/test-require-resolve.js

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -64,6 +64,7 @@ require(fixtures.path('resolve-paths', 'default', 'verify-paths.js'));
6464
if (mod === 'node:quic') return;
6565
// TODO: Remove once node:ffi is no longer flagged
6666
if (mod === 'node:ffi') return;
67+
if (mod === 'node:sqlite' && !common.hasSQLite) return;
6768
assert.strictEqual(require.resolve.paths(mod), null);
6869
if (!mod.startsWith('node:')) {
6970
assert.strictEqual(require.resolve.paths(`node:${mod}`), null);

0 commit comments

Comments
 (0)