Cannot find runtime for instance=com.tns.gen.android.webkit.WebViewClient_vendor_1091_28_WebViewExtImpl@3df2f2d

[gandalfthegreydev]

I'm hitting this crash, randomly, on multiple android devices. Any hint/help ?

[djmaze]

As discussed in NativeScript/android#1667, I understand that this is probably a GC issue related to the fact that the WebViewExtClient holds a WeakRef to the AWebVIew instance, which might get garbage collected.

I do not even understand how that could happen. Or rather I wonder what it means if the AWebView instance has been GCed. Was the native webview gone and reloaded by the system in those cases?

(Neither an Android nor a NativeScript expert, so just mulling it over.)

[gandalfthegreydev]

I've tried to remove the overrides as suggested in the linked issue, but had no effects.

[djmaze]

As this seems to be connected to the V8 GC, I tried switching to a different JavaScript engine with NS 8.9 as a workaround. But it seems rather early with that. At least our app does not work correctly with the Node-API layer, and JS errors seem not be handled or bubbled up the app at all. So unfortunately, that does not help either.

[gandalfthegreydev]

But how do you test if it's working properly? Are you able to reproduce the issue ?

[djmaze]

But how do you test if it's working properly? Are you able to reproduce the issue ?

No, I don't have a good solution for that either. Maybe it would help switching the phone to energy saving mode in order to force more aggressive GC runs?

[gandalfthegreydev]

As suggested on Discord, seems that commenting out these lines, fixed the issue. I didn't get any more report after testing with these lines commented.

ui-webview/src/webview/index.android.ts

Line 665 in 4bfe01c

nativeView.client = client;

ui-webview/src/webview/index.android.ts

Line 669 in 4bfe01c

nativeView.client = client;

ui-webview/src/webview/index.android.ts

Line 674 in 4bfe01c

nativeView.chromeClient = chromeClient;

ui-webview/src/webview/index.android.ts

Line 678 in 4bfe01c

nativeView.bridgeInterface = bridgeInterface;

[djmaze]

These changes look.. interesting. Do you a link to the message where this is explained?

[gandalfthegreydev]

These changes look.. interesting. Do you a link to the message where this is explained?

Not explained, just a suggestion and "seems" to work.
https://discord.com/channels/603595811204366337/606457523574407178/1374863066704908330

[gandalfthegreydev]

no more crashes after commenting that lines

[gandalfthegreydev]

Still no more crashes, so I can confirm that commenting the lines shown above fixed the issue.
Any chance to have this fix merged ?

[djmaze]

The change is on master now (0bea13f).

[farfromrefug]

@djmaze @gandalfthegreydev sorry i thought it was released. The build seems broken. Will have to loom at this

[farfromrefug]

@djmaze @gandalfthegreydev just mqde a new release