Skip to content

Commit 53620d7

Browse files
Copilotbaywet
andcommitted
refactor: use OpenApiConstants for extension name
- Added UnevaluatedPropertiesExtension constant to OpenApiConstants - Replaced hardcoded "x-jsonschema-unevaluatedProperties" strings with constant - Updated both V3.0 and V2.0 serialization paths - Updated PublicAPI.Unshipped.txt with new constant Co-authored-by: baywet <7905502+baywet@users.noreply.github.com>
1 parent 80fc0f6 commit 53620d7

File tree

3 files changed

+10
-4
lines changed

3 files changed

+10
-4
lines changed

src/Microsoft.OpenApi/Models/OpenApiConstants.cs

Lines changed: 5 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -125,6 +125,11 @@ public static class OpenApiConstants
125125
/// </summary>
126126
public const string UnevaluatedProperties = "unevaluatedProperties";
127127

128+
/// <summary>
129+
/// Extension: x-jsonschema-unevaluatedProperties
130+
/// </summary>
131+
public const string UnevaluatedPropertiesExtension = "x-jsonschema-unevaluatedProperties";
132+
128133
/// <summary>
129134
/// Field: Version
130135
/// </summary>

src/Microsoft.OpenApi/Models/OpenApiSchema.cs

Lines changed: 4 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -546,14 +546,14 @@ private void SerializeInternal(IOpenApiWriter writer, OpenApiSpecVersion version
546546
if (UnevaluatedPropertiesSchema is not null)
547547
{
548548
writer.WriteOptionalObject(
549-
"x-jsonschema-unevaluatedProperties",
549+
OpenApiConstants.UnevaluatedPropertiesExtension,
550550
UnevaluatedPropertiesSchema,
551551
callback);
552552
}
553553
// Write boolean false as extension if explicitly set to false
554554
else if (!UnevaluatedProperties)
555555
{
556-
writer.WritePropertyName("x-jsonschema-unevaluatedProperties");
556+
writer.WritePropertyName(OpenApiConstants.UnevaluatedPropertiesExtension);
557557
writer.WriteValue(false);
558558
}
559559
}
@@ -819,14 +819,14 @@ private void SerializeAsV2(
819819
if (UnevaluatedPropertiesSchema is not null)
820820
{
821821
writer.WriteOptionalObject(
822-
"x-jsonschema-unevaluatedProperties",
822+
OpenApiConstants.UnevaluatedPropertiesExtension,
823823
UnevaluatedPropertiesSchema,
824824
(w, s) => s.SerializeAsV2(w));
825825
}
826826
// Write boolean false as extension if explicitly set to false
827827
else if (!UnevaluatedProperties)
828828
{
829-
writer.WritePropertyName("x-jsonschema-unevaluatedProperties");
829+
writer.WritePropertyName(OpenApiConstants.UnevaluatedPropertiesExtension);
830830
writer.WriteValue(false);
831831
}
832832

src/Microsoft.OpenApi/PublicAPI.Unshipped.txt

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -1,4 +1,5 @@
11
#nullable enable
2+
const Microsoft.OpenApi.OpenApiConstants.UnevaluatedPropertiesExtension = "x-jsonschema-unevaluatedProperties" -> string!
23
Microsoft.OpenApi.IOpenApiSchemaWithUnevaluatedProperties
34
Microsoft.OpenApi.IOpenApiSchemaWithUnevaluatedProperties.UnevaluatedPropertiesSchema.get -> Microsoft.OpenApi.IOpenApiSchema?
45
Microsoft.OpenApi.OpenApiSchema.UnevaluatedPropertiesSchema.get -> Microsoft.OpenApi.IOpenApiSchema?

0 commit comments

Comments
 (0)