From eb61a01a3bda5c7e3ba6302a6fd565024ebae4d5 Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?Hynek=20Dav=C3=ADdek?= Date: Wed, 17 Dec 2025 09:43:16 +0100 Subject: [PATCH 1/2] Initialize pool manager with timeout --- massive/rest/base.py | 6 ++++-- 1 file changed, 4 insertions(+), 2 deletions(-) diff --git a/massive/rest/base.py b/massive/rest/base.py index 66c28924..e8e83bc9 100644 --- a/massive/rest/base.py +++ b/massive/rest/base.py @@ -68,6 +68,9 @@ def __init__( backoff_factor=0.1, # [0.0s, 0.2s, 0.4s, 0.8s, 1.6s, ...] ) + # https://urllib3.readthedocs.io/en/stable/reference/urllib3.util.html#urllib3.util.Timeout + timeout = urllib3.Timeout(connect=connect_timeout, read=read_timeout) + # https://urllib3.readthedocs.io/en/stable/reference/urllib3.poolmanager.html # https://urllib3.readthedocs.io/en/stable/reference/urllib3.connectionpool.html#urllib3.HTTPConnectionPool self.client = urllib3.PoolManager( @@ -76,10 +79,9 @@ def __init__( ca_certs=certifi.where(), cert_reqs="CERT_REQUIRED", retries=retry_strategy, # use the customized Retry instance + timeout=timeout, # set timeout for each request ) - self.timeout = urllib3.Timeout(connect=connect_timeout, read=read_timeout) - if verbose: logger.setLevel(logging.DEBUG) self.trace = trace From 70acdb5f70ac26c1dfc10ac0c6b94e4be1311633 Mon Sep 17 00:00:00 2001 From: justinpolygon <123573436+justinpolygon@users.noreply.github.com> Date: Thu, 26 Feb 2026 07:32:09 -0800 Subject: [PATCH 2/2] chore: expose self.timeout on BaseClient + minor cleanup --- massive/rest/base.py | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/massive/rest/base.py b/massive/rest/base.py index e8e83bc9..3349d7ef 100644 --- a/massive/rest/base.py +++ b/massive/rest/base.py @@ -69,7 +69,7 @@ def __init__( ) # https://urllib3.readthedocs.io/en/stable/reference/urllib3.util.html#urllib3.util.Timeout - timeout = urllib3.Timeout(connect=connect_timeout, read=read_timeout) + self.timeout = urllib3.Timeout(connect=connect_timeout, read=read_timeout) # https://urllib3.readthedocs.io/en/stable/reference/urllib3.poolmanager.html # https://urllib3.readthedocs.io/en/stable/reference/urllib3.connectionpool.html#urllib3.HTTPConnectionPool @@ -79,7 +79,7 @@ def __init__( ca_certs=certifi.where(), cert_reqs="CERT_REQUIRED", retries=retry_strategy, # use the customized Retry instance - timeout=timeout, # set timeout for each request + timeout=self.timeout, # set timeout for each request ) if verbose: