pypi distribution is not working perfectly

[shimwell]

the install option of pip install parametric-plasma-source is not quite working

I think this is because the newest version does some cmake commands

One solution might be to move to a conda install / conda distribution

[shimwell]

In the mean time users can always clone the repo and install using python setup.py install

[shimwell]

Thanks for taking a look at this @DanShort12 and pointing out that the pypi upload doesn't contain the wheels.

[shimwell]

The python.yml github actions has an upload wheels stage but I'm not sure if this line does anything at the moment

parametric-plasma-source/.github/workflows/python.yml

Line 42 in e28622d

uses: actions/upload-artifact@v2

[DanShort12]

The python.yml github actions has an upload wheels stage but I'm not sure if this line does anything at the moment

parametric-plasma-source/.github/workflows/python.yml

Line 42 in e28622d

uses: actions/upload-artifact@v2

The 'upload-artifact' action will make the artifacts available outside of the action e.g. this, but won't 'upload' in the sense of putting it on PyPI.

[DanShort12]

I had a go at the PyPI upload on TestPyPI and realized that this isn't building a manylinux package. I might have to take a look at getting the relevant docker image (or to work out why the install from tar.gz can't find cmake!).

[qingfengxia]

The cmake assuming openmc is installed to /opt/openmc while the installation can be detected by cmake: find_program() just as
which openmc will give the full path of openmc, from that openmc_DIR can be retrieved.

[DanShort12]

Fair point that the OpenMC install location isn't being detected (that's a hand over from the original makefile implementation). However, I think the issue @shimwell reports here is related to pip not using the wheel that's created by CI, due to the install not using a manylinux-compatible image.