diff --git a/.eslintrc.json b/.eslintrc.json index d90d7f65..35fac258 100644 --- a/.eslintrc.json +++ b/.eslintrc.json @@ -11,8 +11,7 @@ "extends": [ "plugin:@typescript-eslint/recommended", "plugin:@angular-eslint/recommended", - "plugin:@angular-eslint/template/process-inline-templates", - "prettier" + "plugin:@angular-eslint/template/process-inline-templates" ], "plugins": ["eslint-plugin-no-null", "eslint-plugin-unicorn"], "rules": { @@ -28,7 +27,7 @@ "@angular-eslint/no-pipe-impure": "error", "@angular-eslint/no-queries-metadata-property": "error", "@angular-eslint/prefer-output-readonly": "error", - "@angular-eslint/prefer-standalone": "off", + "@angular-eslint/prefer-standalone": "error", "@angular-eslint/use-component-selector": "error", "@angular-eslint/use-component-view-encapsulation": "error", "@angular-eslint/prefer-inject": "off", diff --git a/.github/PULL_REQUEST_TEMPLATE.md b/.github/PULL_REQUEST_TEMPLATE.md index a8e827b1..ddf1d789 100644 --- a/.github/PULL_REQUEST_TEMPLATE.md +++ b/.github/PULL_REQUEST_TEMPLATE.md @@ -1,4 +1,5 @@ ## Description + Please include a summary of the change, motivation and context. - ### Testing -Please describe the tests that you ran to verify your changes. Please summarize what did you test and what needs to be tested e.g. deployed and tested helm chart locally. + +Please describe the tests that you ran to verify your changes. Please summarize what did you test and what needs to be tested e.g. deployed and tested helm chart locally. ### Checklist: + - [ ] My changes generate no new warnings - [ ] I have added tests that prove my fix is effective or that my feature works - [ ] Any dependent changes have been merged and published in downstream modules ### Documentation + Make sure that you have documented corresponding changes in this repository or [hypertrace docs repo](https://github.com/hypertrace/hypertrace-docs-website) if required.