Remove service start call from examples/stream

Author: h2zero

examples/Bluetooth_5/NimBLE_extended_server/NimBLE_extended_server.ino

@@ -98,9 +98,6 @@ void setup() {
 
     pCharacteristic->setValue("Hello World");
 
-    /** Start the service */
-    pService->start();
-
     /**
      *  Create an extended advertisement with the instance ID 0 and set the PHY's.
      *  Multiple instances can be added as long as the instance ID is incremented.

examples/Bluetooth_5/NimBLE_multi_advertiser/NimBLE_multi_advertiser.ino

@@ -116,9 +116,6 @@ void setup() {
 
     pCharacteristic->setValue("Hello World");
 
-    /** Start the service */
-    pService->start();
-
     /** Create our multi advertising instances */
 
     /** extended scannable instance advertising on coded and 1m PHY's. */

examples/L2CAP/L2CAP_Server/L2CAP_Server.ino

@@ -70,7 +70,6 @@ void setup() {
     auto service        = server->createService(SERVICE_UUID);
     auto characteristic = service->createCharacteristic(CHARACTERISTIC_UUID, NIMBLE_PROPERTY::READ);
     characteristic->setValue(L2CAP_CHANNEL);
-    service->start();
 
     auto advertising = BLEDevice::getAdvertising();
     advertising->addServiceUUID(SERVICE_UUID);

examples/NimBLE_Secure_Server/NimBLE_Secure_Server.ino

@@ -29,7 +29,6 @@ void setup() {
         pService->createCharacteristic("1235",
                                        NIMBLE_PROPERTY::READ | NIMBLE_PROPERTY::READ_ENC | NIMBLE_PROPERTY::READ_AUTHEN);
 
-    pService->start();
     pNonSecureCharacteristic->setValue("Hello Non Secure BLE");
     pSecureCharacteristic->setValue("Hello Secure BLE");
 

examples/NimBLE_Server/NimBLE_Server.ino

@@ -186,10 +186,6 @@ void setup(void) {
     pC01Ddsc->setValue("Send it back!");
     pC01Ddsc->setCallbacks(&dscCallbacks);
 
-    /** Start the services when finished creating all Characteristics and Descriptors */
-    pDeadService->start();
-    pBaadService->start();
-
     /** Create an advertising instance and add the services to the advertised data */
     NimBLEAdvertising* pAdvertising = NimBLEDevice::getAdvertising();
     pAdvertising->setName("NimBLE-Server");

examples/NimBLE_Server_Whitelist/NimBLE_Server_Whitelist.ino

@@ -55,7 +55,6 @@ void setup() {
     pCharacteristic =
         pService->createCharacteristic(CHARACTERISTIC_UUID,
                                        NIMBLE_PROPERTY::READ | NIMBLE_PROPERTY::WRITE | NIMBLE_PROPERTY::NOTIFY);
-    pService->start();
 
     NimBLEAdvertising* pAdvertising = NimBLEDevice::getAdvertising();
     pAdvertising->addServiceUUID(SERVICE_UUID);

src/NimBLEStream.cpp

@@ -607,6 +607,8 @@ bool NimBLEStreamServer::begin(
     if (!pSvc) {
         return false;
     }
+    
+    m_deleteSvcOnEnd = true; // mark service for deletion on end since we created it here
 
     // Create characteristic with notify + write properties for bidirectional stream
     uint32_t props = 0;
@@ -630,13 +632,6 @@ bool NimBLEStreamServer::begin(
         goto error;
     }
 
-    m_deleteSvcOnEnd = true; // mark service for deletion on end since we created it here
-
-    if (!pSvc->start()) {
-        NIMBLE_LOGE(LOG_TAG, "Failed to start service");
-        goto error;
-    }
-
     if (!begin(pChr, txBufSize, rxBufSize)) {
         NIMBLE_LOGE(LOG_TAG, "Failed to initialize stream with characteristic");
         goto error;