Fix e2e screenshot: skip snap stub, find real chromium binary

The base image has /usr/bin/chromium-browser as a snap wrapper stub
that prints "requires the chromium snap". Now search for the actual
chromium binary at /usr/lib/chromium/chromium first, skipping any
snap stubs. Add diagnostic output if no working binary is found.

Author: guysoft

testing/hooks/screenshot.sh

@@ -34,28 +34,36 @@ HTTP_PORT="${QEMU_HTTP_PORT:-8080}"
 echo "  Checking forwarded port accessibility..."
 curl -s -o /dev/null -w "  Port $HTTP_PORT -> HTTP %{http_code}\n" "http://localhost:${HTTP_PORT}" || echo "  Port $HTTP_PORT not reachable"
 
-for BROWSER in chromium chromium-browser; do
-    BROWSER_PATH=$(command -v "$BROWSER" 2>/dev/null || true)
-    if [ -n "$BROWSER_PATH" ]; then
-        echo "  Taking headless screenshot with $BROWSER_PATH ..."
-        "$BROWSER_PATH" \
-            --headless=new \
-            --no-sandbox \
-            --disable-gpu \
-            --disable-software-rasterizer \
-            --disable-dev-shm-usage \
-            --virtual-time-budget=15000 \
-            --screenshot="$ARTIFACTS_DIR/screenshot.png" \
-            --window-size=1280,720 \
-            "http://localhost:${HTTP_PORT}" 2>&1 | tail -5 || true
-        if [ -f "$ARTIFACTS_DIR/screenshot.png" ]; then
-            echo "  Screenshot saved to $ARTIFACTS_DIR/screenshot.png"
-            ls -la "$ARTIFACTS_DIR/screenshot.png"
-            exit 0
-        else
-            echo "  Screenshot file was NOT created by $BROWSER"
-        fi
+# Find real chromium binary (skip snap stubs that print "requires the chromium snap")
+BROWSER_PATH=""
+for candidate in /usr/lib/chromium/chromium /usr/bin/chromium /snap/bin/chromium; do
+    if [ -x "$candidate" ] && ! "$candidate" --version 2>&1 | grep -q "snap"; then
+        BROWSER_PATH="$candidate"
+        break
     fi
 done
 
-echo "  No screenshot produced (headless browser may have failed)"
+if [ -n "$BROWSER_PATH" ]; then
+    echo "  Taking headless screenshot with $BROWSER_PATH ..."
+    "$BROWSER_PATH" \
+        --headless=new \
+        --no-sandbox \
+        --disable-gpu \
+        --disable-software-rasterizer \
+        --disable-dev-shm-usage \
+        --virtual-time-budget=15000 \
+        --screenshot="$ARTIFACTS_DIR/screenshot.png" \
+        --window-size=1280,720 \
+        "http://localhost:${HTTP_PORT}" 2>&1 | tail -10 || true
+    if [ -f "$ARTIFACTS_DIR/screenshot.png" ]; then
+        echo "  Screenshot saved to $ARTIFACTS_DIR/screenshot.png"
+        ls -la "$ARTIFACTS_DIR/screenshot.png"
+    else
+        echo "  Screenshot file was NOT created"
+    fi
+else
+    echo "  No working chromium binary found. Checking available:"
+    ls -la /usr/bin/chromium* /usr/lib/chromium/chromium 2>&1 || true
+    echo "  dpkg -l chromium:"
+    dpkg -l chromium 2>&1 | tail -3 || true
+fi