Use HWY_ABORT instead of std::cerr for overflow checks in ReadPPM

sharadboni · sharadboni · commit c4d14dbc22f4 · 2026-04-16T09:02:08.000-07:00
diff --git a/paligemma/image.cc b/paligemma/image.cc
@@ -140,11 +140,11 @@ bool Image::ReadPPM(const hwy::Span<const char>& buf) {
   }
   ++pos;
   if (width == 0 || height == 0) {
-    std::cerr << "Invalid zero dimension\n";
+    HWY_ABORT("Invalid zero dimension\n");
     return false;
   }
   if (width > SIZE_MAX / 3 || width * 3 > SIZE_MAX / height) {
-    std::cerr << "Image dimensions overflow\n";
+    HWY_ABORT("Image dimensions overflow\n");
     return false;
   }
   const size_t data_size = width * height * 3;

Original file line number	Diff line number	Diff line change
`@@ -140,11 +140,11 @@ bool Image::ReadPPM(const hwy::Span<const char>& buf) {`
`140`	`140`	`}`
`141`	`141`	`++pos;`
`142`	`142`	`if (width == 0 \|\| height == 0) {`
`143`		`- std::cerr << "Invalid zero dimension\n";`
	`143`	`+ HWY_ABORT("Invalid zero dimension\n");`
`144`	`144`	`return false;`
`145`	`145`	`}`
`146`	`146`	`if (width > SIZE_MAX / 3 \|\| width * 3 > SIZE_MAX / height) {`
`147`		`- std::cerr << "Image dimensions overflow\n";`
	`147`	`+ HWY_ABORT("Image dimensions overflow\n");`
`148`	`148`	`return false;`
`149`	`149`	`}`
`150`	`150`	`const size_t data_size = width * height * 3;`