feat(groups): implement change_group_member_permission and fix type h…

[amangupta982]

feat(groups): implement change_group_member_permission and fix type hints

Summary

This PR adds the missing change_group_member_permission() method to the Groups
class, which wraps the PATCH /groups/{group_id}/user/{user_id} API endpoint.
It also fixes missing return type annotations across groups.py and users.py,
and corrects a copy-paste error in the delete_group() docstring.

Changes

fossology/groups.py

• feat: Added change_group_member_permission(group_id, user_id, perm) — implements
  the previously unimplemented PATCH /groups/{id}/user/{id} endpoint with full error
  handling for status codes 200, 400, 403, 404, and 5xx
• fix: Added -> None return type annotations to create_group(), delete_group(),
  add_group_member(), and delete_group_member()
• fix: Corrected delete_group() docstring (was copy-pasted from create_group())

fossology/users.py

• fix: Added type annotations to detail_user(user_id: int) -> "User",
  list_users() -> list, create_user(user_spec: dict) -> None,
  and delete_user(user: "User") -> None

tests/test_groups.py

• Added 5 new test cases for change_group_member_permission():
  • test_change_group_member_permission_validation_error (400)
  • test_change_group_member_permission_not_authorized (403)
  • test_change_group_member_permission_not_found (404)
  • test_change_group_member_permission_server_error (500)
  • test_change_group_member_permission (happy path, with live server fixture)

How to Test

# Run only the new tests (mocked, no server needed)
poetry run pytest tests/test_groups.py -k "change_group_member_permission" -v

# Run the full groups test suite
poetry run pytest tests/test_groups.py -v

# Run with coverage
poetry run coverage run --source=fossology -m pytest tests/test_groups.py tests/test_users.py
poetry run coverage report -m

Related

The PATCH /groups/{group_id}/user/{user_id} endpoint existed in the FOSSology REST
API but had no corresponding Python wrapper method. Users who needed to change a group
member's permission had to delete and re-add the member as a workaround.

Checklist

• New feature follows the existing code style and patterns
• Return type annotations added to all modified/new functions
• Full docstring with :param:, :type:, and :raises: added
• Error handling for all documented HTTP status codes (400, 403, 404, 5xx)
• Unit tests added for all error paths (mocked with @responses.activate)
• Integration test added for the happy path
• No breaking changes to existing API

[amangupta982]

Hi maintainers! I'm a student interested in contributing to FOSSology. This is my first PR — happy to make any changes based on your feedback.

[amangupta982]

Hi @maintainers 👋
I've submitted this PR to implement the missing change_group_member_permission() method for the PATCH /groups/{id}/user/{id} endpoint, along with type hint fixes and tests.
Could you please approve the workflow run so the CI checks can execute? Happy to make any changes based on your feedback. Thank you!

[deveaud-m]

@amangupta982 thanks for the PR.

As you can see the tests are infortunatly failing. Could you make sure the testsuite pass on your test setup and provide a fix to this PR ensuring all the tests are succesful?

[amangupta982]

@amangupta982 thanks for the PR.

As you can see the tests are infortunatly failing. Could you make sure the testsuite pass on your test setup and provide a fix to this PR ensuring all the tests are succesful?

Hi @deveaud-m , thank you for the review!
I investigated the failure carefully. The failing test test_uploads.py::test_upload_for_group is not related to my changes — I only modified fossology/groups.py, fossology/users.py, and tests/test_groups.py.
The failure is caused by the shared CI server already having previous uploads. When list_uploads(group="upload_access") is called, it returns zlib_1.2.11 (a leftover upload from a prior test run) instead of the freshly uploaded base-files_11.tar.xz. This is a test isolation issue in the existing test suite.
My changes result in:

✅ Static Checks passing on Python 3.11 and 3.12
✅ All 17 group tests passing
✅ No conflicts with base branch

Could you check if test_upload_for_group was already failing on main before my PR was opened? I believe this is a pre-existing flaky test unrelated to my contribution.