Error: spawn EINVAL / node 22 breaks `devcontainer up`

[agardnerIT]

I believe this is due to a breaking change in node 22. I also believe the fix is to use the nodeJS options: spawn(command, args, { shell: true }); but that's a change to the CLI as we can't pass that in...

devcontainer up
[2 ms] @devcontainers/cli 0.83.0. Node.js v22.13.1. win32 10.0.26200 x64.
Error: spawn EINVAL
    at ChildProcess.spawn (node:internal/child_process:420:11)
    at Object.spawn (node:child_process:753:9)

[ishwar170695]

I traced the non-PTY execution path and it seems devcontainer up eventually calls child_process.spawn() through plainExec() in src/spec-common/commonUtils.ts.

cp.spawn(exec, args, { cwd, env, stdio: stdio as any, windowsHide: true });

ExecParameters.args is optional (args?: string[]), so spawn() may receive "undefined" instead of an array. Node 22 might reject this and throw "spawn EINVAL".

The PTY path already guards against this with args || [], but the non-PTY path does not.

Would defaulting args in plainExec like this make sense?

cp.spawn(exec, args ?? [], { cwd, env, stdio: stdio as any, windowsHide: true });

[ishwar170695]

Does this hypothesis seem correct to you?