scoreboard problem when quiting

[rafalohaki]

Describe the bug

When i leave the server i was getting this error

[20:17:52 ERROR]: Could not pass event PlayerQuitEvent to Akropolis v1.9.3
java.lang.NullPointerException: Cannot invoke "me.zetastormy.akropolis.module.modules.visual.scoreboard.ScoreboardHelper.removePlayer()" because the return value of "java.util.Map.get(Object)" is null
	at Akropolis-1.9.3.jar/me.zetastormy.akropolis.module.modules.visual.scoreboard.ScoreboardManager.removeScoreboard(ScoreboardManager.java:105) ~[Akropolis-1.9.3.jar:?]
	at Akropolis-1.9.3.jar/me.zetastormy.akropolis.module.modules.visual.scoreboard.ScoreboardManager.onPlayerQuit(ScoreboardManager.java:133) ~[Akropolis-1.9.3.jar:?]
	at org.bukkit.plugin.RegisteredListener.callEvent(RegisteredListener.java:71) ~[leaf-api-1.21.8-R0.1-SNAPSHOT.jar:?]
	at io.papermc.paper.plugin.manager.PaperEventManager.callEvent(PaperEventManager.java:65) ~[leaf-1.21.8.jar:1.21.8-12-7992f91]
	at io.papermc.paper.plugin.manager.PaperPluginManagerImpl.callEvent(PaperPluginManagerImpl.java:131) ~[leaf-1.21.8.jar:1.21.8-12-7992f91]
	at org.bukkit.plugin.SimplePluginManager.callEvent(SimplePluginManager.java:629) ~[leaf-api-1.21.8-R0.1-SNAPSHOT.jar:?]
	at net.minecraft.server.players.PlayerList.remove(PlayerList.java:706) ~[leaf-1.21.8.jar:1.21.8-12-7992f91]
	at net.minecraft.server.players.PlayerList.remove(PlayerList.java:689) ~[leaf-1.21.8.jar:1.21.8-12-7992f91]
	at net.minecraft.server.network.ServerGamePacketListenerImpl.removePlayerFromWorld(ServerGamePacketListenerImpl.java:2292) ~[leaf-1.21.8.jar:1.21.8-12-7992f91]
	at net.minecraft.server.network.ServerGamePacketListenerImpl.onDisconnect(ServerGamePacketListenerImpl.java:2270) ~[leaf-1.21.8.jar:1.21.8-12-7992f91]
	at net.minecraft.network.Connection.handleDisconnection(Connection.java:904) ~[leaf-1.21.8.jar:1.21.8-12-7992f91]
	at net.minecraft.server.network.ServerConnectionListener.tick(ServerConnectionListener.java:270) ~[leaf-1.21.8.jar:1.21.8-12-7992f91]
	at net.minecraft.server.MinecraftServer.tickConnection(MinecraftServer.java:1820) ~[leaf-1.21.8.jar:1.21.8-12-7992f91]
	at net.minecraft.server.dedicated.DedicatedServer.tickConnection(DedicatedServer.java:447) ~[leaf-1.21.8.jar:1.21.8-12-7992f91]
	at net.minecraft.server.MinecraftServer.tickChildren(MinecraftServer.java:1800) ~[leaf-1.21.8.jar:1.21.8-12-7992f91]
	at net.minecraft.server.MinecraftServer.tickServer(MinecraftServer.java:1567) ~[leaf-1.21.8.jar:1.21.8-12-7992f91]
	at net.minecraft.server.MinecraftServer.runServer(MinecraftServer.java:1285) ~[leaf-1.21.8.jar:1.21.8-12-7992f91]
	at net.minecraft.server.MinecraftServer.lambda$spin$0(MinecraftServer.java:299) ~[leaf-1.21.8.jar:1.21.8-12-7992f91]
	at java.base/java.lang.Thread.run(Thread.java:1447) ~[?:?]

made some workaround fix
https://github.com/rafalohaki/akropolis
you can use any added code in fork or make ur own based on this if u want

Link to latest.log file

https://mclo.gs/GJ5naV4

Steps to reproduce

using server selector, when joining other server from lobby iw as getting this error

Expected behavior

error logs

Technical information

leaf 1.21.8

Additional context

No response

[zetastormy]

Thank you for reporting!

I tried to reproduce this bug using Paper version 1.21.8-10-c8a8c0e, but nothing happens, so I assume this bug may be specific to the Paper fork you are using (Leaf). The place where this bug happens is really weird, so I assume it has to do with some of the optimizations done by Leaf.

I will try to fix it based on the changes you made on your Akropolis fork, thank you.