Skip to content

Commit dd0245d

Browse files
ci(kernel-e2e): drop --interpreter from maturin develop (not a valid flag)
maturin develop installs into whichever python invoked it; the flag exists on `maturin build` only. The previous commit's extra `--interpreter $CONNECTOR_VENV_PY` was redundant — we're already calling maturin via `$CONNECTOR_VENV_PY -m maturin`, so the venv python is the one doing the build and install. Co-authored-by: Isaac Signed-off-by: Vikrant Puppala <vikrant.puppala@databricks.com>
1 parent 93f76dd commit dd0245d

1 file changed

Lines changed: 6 additions & 6 deletions

File tree

.github/workflows/kernel-e2e.yml

Lines changed: 6 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -290,12 +290,12 @@ jobs:
290290
291291
- name: Build + install kernel wheel into connector venv
292292
working-directory: databricks-sql-kernel/pyo3
293-
# `--interpreter $CONNECTOR_VENV_PY` pins maturin to the
294-
# connector venv even though we're cwd'd inside the kernel's
295-
# own pyproject tree. `python -m maturin` invokes the
296-
# maturin we just installed into that same venv, sidestepping
297-
# the nested-poetry-project detection entirely.
298-
run: $CONNECTOR_VENV_PY -m maturin develop --release --interpreter $CONNECTOR_VENV_PY
293+
# `maturin develop` builds the extension against — and installs
294+
# it into — whichever python invoked it. Calling it via
295+
# `$CONNECTOR_VENV_PY -m maturin` from inside the kernel's
296+
# pyo3/ tree is what targets the connector venv without
297+
# tripping poetry's nested-project detection.
298+
run: $CONNECTOR_VENV_PY -m maturin develop --release
299299

300300
- name: Smoke-check kernel import
301301
run: |

0 commit comments

Comments
 (0)