Skip to content

Commit 6be8799

Browse files
committed
integration: post-merge fix — update execution.test.ts assertions
Two assertions in tests/unit/sea/execution.test.ts were specific to the pre-merge SeaBackend / SeaOperationBackend stubs: 1. connect() missing-token rejection now flows through SeaAuth.buildSeaConnectionOptions which throws AuthenticationError (still a HiveDriverError subclass) with message "non-empty PAT". Updated the regex match accordingly. 2. fetchChunk() is no longer a stub — the merged SeaOperationBackend uses the sea-results pipeline (SeaResultsProvider + ArrowResultConverter + ResultSlicer). The "throws M1-deferred error owned by sea-results" test is now incorrect by design; removed it with a pointer comment to the real coverage in SeaOperationBackend.test.ts and results-e2e.test.ts. 891/891 unit tests passing post-merge. Signed-off-by: Madhavendra Rathore <madhavendra.rathore@databricks.com>
1 parent 0a1c02d commit 6be8799

1 file changed

Lines changed: 9 additions & 12 deletions

File tree

tests/unit/sea/execution.test.ts

Lines changed: 9 additions & 12 deletions
Original file line numberDiff line numberDiff line change
@@ -171,7 +171,10 @@ describe('SeaBackend', () => {
171171
thrown = err;
172172
}
173173
expect(thrown).to.be.instanceOf(HiveDriverError);
174-
expect((thrown as Error).message).to.match(/token is required/);
174+
// After sea-integration merge, missing-token validation goes through
175+
// SeaAuth.buildSeaConnectionOptions which throws AuthenticationError
176+
// (extends HiveDriverError) with the "non-empty PAT" message.
177+
expect((thrown as Error).message).to.match(/non-empty PAT/);
175178
});
176179

177180
it('openSession() throws if connect() was not called', async () => {
@@ -448,15 +451,9 @@ describe('SeaOperationBackend', () => {
448451
await op.waitUntilReady();
449452
});
450453

451-
it('fetchChunk() throws M1-deferred error (owned by sea-results)', async () => {
452-
const op = makeOperation();
453-
let thrown: unknown;
454-
try {
455-
await op.fetchChunk({ limit: 100 });
456-
} catch (err) {
457-
thrown = err;
458-
}
459-
expect(thrown).to.be.instanceOf(HiveDriverError);
460-
expect((thrown as Error).message).to.match(/sea-results/);
461-
});
454+
// Note: after sea-integration merge, fetchChunk is no longer a stub —
455+
// the sea-results SeaResultsProvider + ArrowResultConverter pipeline
456+
// implements the real fetch path. Full coverage lives in
457+
// tests/unit/sea/SeaOperationBackend.test.ts and the parity-gate e2e
458+
// at tests/integration/sea/results-e2e.test.ts.
462459
});

0 commit comments

Comments
 (0)