makes #555 less aggressive#583
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
PR #555 fixed an issue where CKEditor fields with list items would get marked as dirty before any changes were actually made to them. In order to achieve that, the Element Editor’s form observer was paused before the initial call to
updateSourceElement().That change was a bit too aggressive and caused the “Copy value from site” functionality to not fully work as expected. That functionality replaces the entire field’s DOM and re-initialises the CKEditor field, so the field’s
create()method is called again, and the content copied from the other site was treated as an initial value. (This, in turn, caused the field to not be marked as dirty and the updated content was not saved.)Related issues
#580