-
Notifications
You must be signed in to change notification settings - Fork 0
Open
coder/coder
#23315Labels
Description
CI Run: https://github.com/coder/coder/actions/runs/23307509845
Commit: 0176a5dd6bd1702ae929bfbf8e7ad11c87232872 (Danielle Maywood)
Job: test-e2e
Failure summary:
- Playwright test failed: [tests] › e2e/tests/workspaces/createWorkspace.spec.ts:112:5 › create workspace and overwrite default parameters
- Parameter verification mismatch for a boolean value; expected override value "false" but UI reported "true".
Error excerpt:
1) [tests] › e2e/tests/workspaces/createWorkspace.spec.ts:112:5 › create workspace and overwrite default parameters
Error: expect(received).toEqual(expected) // deep equality
Expected: "false"
Received: "true"
at helpers.ts:215
213 | const parameterField = parameterLabel.locator("input");
214 | const value = await parameterField.isChecked();
> 215 | expect(value.toString()).toEqual(buildParameter.value);
| ^
216 | }
Timing verification:
- Job completed at 2026-03-19T17:26:38Z, within minutes of the Slack alert.
Root cause assessment:
- Likely flaky UI/parameter hydration for boolean parameters. The test sets the boolean parameter to "false" when creating the workspace, but
verifyParametersreads the checkbox as checked (true). Unlike string/number paths, the bool path usesisChecked()without retry; it can capture a stale default value before data hydration completes.
Assignment analysis:
git blame -L 205,218 site/e2e/helpers.ts→ commit b73f216 ("flake: verify parameters in parallel in e2e tests") by @jeremyruppel, which touched theverifyParameterslogic and is closest to the failing line.git log --oneline -10 --follow site/e2e/tests/workspaces/createWorkspace.spec.tsshows no recent targeted changes to this test, suggesting the issue is in shared verification logic rather than the test itself.
Related issues:
- flake: e2e create workspace with default and required parameters #1154 (parameter verification flake with empty values)
- flake: update workspace, new required, mutable parameter added #1328 (parameter verification flake after update)
Reproduction:
pnpm playwright:test --forbid-only --workers 1 --grep "create workspace and overwrite default parameters"
Reactions are currently unavailable