Skip to content

code and video mismatch #69

@yww325

Description

@yww325

in the code https://github.com/codecraft-tv/angular-course/blob/current/5.built-in-directives/2.ngfor/code/src/main.ts#L40
*ngfor is on ul element for GroupByCountry example, and <li> is only wrapping the country name. there is an extra empty line after the inner ul displayed., which is after each country. (I don't know why <ul> element has to have an extra line though, can you show me?)

However, in the video https://codecraft.tv/courses/angular/built-in-directives/ngfor/
the *ngfor is on li element and the inner ul element is wrapped as part of the <li>
there is no extra empty line between each <li>, or say each country.

Metadata

Metadata

Assignees

No one assigned

    Labels

    No labels
    No labels

    Type

    No type
    No fields configured for issues without a type.

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions