Fix macroexpand list? and array exception types

- Align when/when-not macros to upstream: use (list ...) instead of
  syntax-quote to return PersistentList (fixes list? on macroexpand)
- Change negative array size error from type_error to value_error
  (IllegalArgumentException, not ClassCastException)
- Update arrays.clj test: Exception instead of ExceptionInfo
- All 49/49 upstream tests pass on both backends

Author: chaploud

.dev/memo.md

@@ -36,16 +36,16 @@ Phase 53: Hardening & pprint Tests (complete)
 - 53.4: Fixed BigDecimal exponent notation
 - 53.5: Fixed colon in symbol/keyword literals
 - 53.6: Ported pprint tests (12 tests, 78 assertions, content-equivalent)
-- 53.7: Full regression — 47/49 VM, 47/49 TW (2 pre-existing), 6/6 e2e
+- 53.7: Full regression — 49/49 VM, 49/49 TW, 6/6 e2e
+- 53.8: Fix macroexpand list? (when macro upstream alignment)
+- 53.9: Fix array negative size exception type (value_error)
 
 ## Known Issues
 
 - apply on infinite lazy seq realizes eagerly (deferred — no tests need it)
 - pprint on infinite lazy seq hangs (realizeValue in singleLine/pprintImpl)
 - binding *ns* doesn't affect read-string for auto-resolved keywords
 - Regex capture groups/backreferences not supported
-- arrays.clj: 5 errors — exception type mismatch (ClassCastException vs ExceptionInfo)
-- sci/core_test.clj: 2 fails — macroexpand returns cons, not list (list? false)
 
 ## Notes
 

src/builtins/array.zig

@@ -51,7 +51,7 @@ fn makeArrayMultiDim(allocator: Allocator, dims: []const Value) anyerror!Value {
     const size_val = dims[0];
     if (size_val.tag() != .integer) return err.setErrorFmt(.eval, .type_error, .{}, "make-array size must be integer, got {s}", .{@tagName(size_val.tag())});
     const size_i = size_val.asInteger();
-    if (size_i < 0) return err.setErrorFmt(.eval, .type_error, .{}, "make-array size must be non-negative, got {d}", .{size_i});
+    if (size_i < 0) return err.setErrorFmt(.eval, .value_error, .{}, "make-array size must be non-negative, got {d}", .{size_i});
     const size: usize = @intCast(size_i);
 
     const arr_val = try createArray(allocator, size, .object);
@@ -75,7 +75,7 @@ fn objectArrayFn(allocator: Allocator, args: []const Value) anyerror!Value {
     const arg = args[0];
     if (arg.tag() == .integer) {
         const size_i = arg.asInteger();
-        if (size_i < 0) return err.setErrorFmt(.eval, .type_error, .{}, "object-array size must be non-negative, got {d}", .{size_i});
+        if (size_i < 0) return err.setErrorFmt(.eval, .value_error, .{}, "object-array size must be non-negative, got {d}", .{size_i});
         return createArray(allocator, @intCast(size_i), .object);
     }
     // Collection: convert to array
@@ -308,7 +308,7 @@ fn typedArrayFn(allocator: Allocator, args: []const Value, elem_type: ZigArray.E
     const arg = args[0];
     if (arg.tag() == .integer) {
         const size_i = arg.asInteger();
-        if (size_i < 0) return err.setErrorFmt(.eval, .type_error, .{}, name ++ " size must be non-negative, got {d}", .{size_i});
+        if (size_i < 0) return err.setErrorFmt(.eval, .value_error, .{}, name ++ " size must be non-negative, got {d}", .{size_i});
         return createArray(allocator, @intCast(size_i), elem_type);
     }
     // Collection: convert to typed array

src/clj/clojure/core.clj

@@ -8,8 +8,11 @@
 (defmacro defn [name & fdecl]
   `(def ~name (fn ~name ~@fdecl)))
 
-(defmacro when [test & body]
-  `(if ~test (do ~@body)))
+(defmacro when
+  "Evaluates test. If logical true, evaluates body in an implicit do."
+  {:added "1.0"}
+  [test & body]
+  (list 'if test (cons 'do body)))
 
 ;; Arithmetic helpers
 
@@ -168,8 +171,11 @@
 (defmacro if-not [test then & more]
   `(if (not ~test) ~then ~(first more)))
 
-(defmacro when-not [test & body]
-  `(if (not ~test) (do ~@body)))
+(defmacro when-not
+  "Evaluates test. If logical false, evaluates body in an implicit do."
+  {:added "1.0"}
+  [test & body]
+  (list 'if test nil (cons 'do body)))
 
 ;; Utility functions
 

test/upstream/clojure/test_clojure/arrays.clj

@@ -37,9 +37,9 @@
 (deftest-type-array int-array)
 (deftest-type-array long-array)
 
-;; CLJW: adapted — ExceptionInfo instead of NegativeArraySizeException
+;; CLJW: adapted — Exception instead of NegativeArraySizeException (JVM-specific)
 (deftest test-type-array-exceptions
-  (are [x] (thrown? ExceptionInfo x)
+  (are [x] (thrown? Exception x)
     (int-array -1)
     (long-array -1)
     (float-array -1)
@@ -48,7 +48,8 @@
 ;; CLJW: adapted — type arg is string, removed class checks
 (deftest test-make-array
   ;; negative size
-  (is (thrown? ExceptionInfo (make-array "Integer" -1)))
+  ;; CLJW: Exception instead of NegativeArraySizeException
+  (is (thrown? Exception (make-array "Integer" -1)))
 
   ;; one-dimensional
   (are [x] (= (alength (make-array "Integer" x)) x)