WIP: port to rpgp +1 while keeping the same decryption behavior for SEIPDv1#8266
Draft
hko-s wants to merge 1 commit into
Draft
WIP: port to rpgp +1 while keeping the same decryption behavior for SEIPDv1#8266hko-s wants to merge 1 commit into
hko-s wants to merge 1 commit into
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
rPGP's default behavior while decrypting SEIPDv1 messages has changed from streaming to buffering the full plaintext in memory first: rpgp/rpgp#662
This is more defensive, but may cause OOM problems for applications (which I believe has been a problem for Delta Chat in the past). When applications are able to safely deal with early release of unauthenticated plaintext during decryption, then (re-)opting in to streaming SEIPDv1 decryption is attractive.
The diff in PR shows how to keep the same rPGP decryption characteristics as before when using the (still unfinished) next release.