From 458cfa44b3f49ad71e9e2c2f06f45377342e1c34 Mon Sep 17 00:00:00 2001 From: Vlada Dusek Date: Wed, 13 May 2026 18:59:36 +0200 Subject: [PATCH 1/7] ci: add package verification check Adds an end-to-end check that the built sdist and wheel install cleanly and contain the expected sources via the shared apify/workflows/python-package-check action. Runs on every PR and inside the release flow between prepare-pypi-distribution and the PyPI publish step, guarding against silent build regressions. --- .github/workflows/_check_package.yaml | 29 ++++++++++++++++++++ .github/workflows/manual_release_beta.yaml | 5 ++++ .github/workflows/manual_release_stable.yaml | 5 ++++ .github/workflows/on_pull_request.yaml | 4 +++ 4 files changed, 43 insertions(+) create mode 100644 .github/workflows/_check_package.yaml diff --git a/.github/workflows/_check_package.yaml b/.github/workflows/_check_package.yaml new file mode 100644 index 0000000..de4846a --- /dev/null +++ b/.github/workflows/_check_package.yaml @@ -0,0 +1,29 @@ +name: Package check + +on: + workflow_dispatch: + workflow_call: + +permissions: + contents: read + +jobs: + package_check: + name: Package check + runs-on: ubuntu-latest + steps: + - name: Checkout repository + uses: actions/checkout@v6 + + - name: Set up uv package manager + uses: astral-sh/setup-uv@v8.1.0 + with: + python-version: "3.14" + + - name: Build sdist and wheel + run: uv run poe build + + - name: Verify built package + uses: apify/workflows/python-package-check@main + with: + package_name: apify_shared diff --git a/.github/workflows/manual_release_beta.yaml b/.github/workflows/manual_release_beta.yaml index f56b8ee..ab59342 100644 --- a/.github/workflows/manual_release_beta.yaml +++ b/.github/workflows/manual_release_beta.yaml @@ -60,6 +60,11 @@ jobs: version_number: ${{ needs.release_prepare.outputs.version_number }} ref: ${{ needs.changelog_update.outputs.changelog_commitish }} + - name: Verify built package + uses: apify/workflows/python-package-check@main + with: + package_name: apify_shared + # Publish the package to PyPI using PyPA official GitHub action with OIDC authentication. - name: Publish package to PyPI uses: pypa/gh-action-pypi-publish@release/v1 diff --git a/.github/workflows/manual_release_stable.yaml b/.github/workflows/manual_release_stable.yaml index f5ff240..e992171 100644 --- a/.github/workflows/manual_release_stable.yaml +++ b/.github/workflows/manual_release_stable.yaml @@ -95,6 +95,11 @@ jobs: version_number: ${{ needs.release_prepare.outputs.version_number }} ref: ${{ needs.changelog_update.outputs.changelog_commitish }} + - name: Verify built package + uses: apify/workflows/python-package-check@main + with: + package_name: apify_shared + # Publishes the package to PyPI using PyPA official GitHub action with OIDC authentication. - name: Publish package to PyPI uses: pypa/gh-action-pypi-publish@release/v1 diff --git a/.github/workflows/on_pull_request.yaml b/.github/workflows/on_pull_request.yaml index 13b0e97..4660922 100644 --- a/.github/workflows/on_pull_request.yaml +++ b/.github/workflows/on_pull_request.yaml @@ -17,6 +17,10 @@ jobs: name: Code checks uses: ./.github/workflows/_check_code.yaml + package_check: + name: Package check + uses: ./.github/workflows/_check_package.yaml + tests: name: Tests uses: ./.github/workflows/_tests.yaml From 83b006e770f16772f1eca624de3a73535daa5de8 Mon Sep 17 00:00:00 2001 From: Vlada Dusek Date: Thu, 14 May 2026 11:04:33 +0200 Subject: [PATCH 2/7] ci: pass new required inputs to python-package-check action Co-Authored-By: Claude Opus 4.7 (1M context) --- .github/workflows/_check_package.yaml | 3 +++ .github/workflows/manual_release_beta.yaml | 3 +++ .github/workflows/manual_release_stable.yaml | 3 +++ 3 files changed, 9 insertions(+) diff --git a/.github/workflows/_check_package.yaml b/.github/workflows/_check_package.yaml index de4846a..4da77db 100644 --- a/.github/workflows/_check_package.yaml +++ b/.github/workflows/_check_package.yaml @@ -27,3 +27,6 @@ jobs: uses: apify/workflows/python-package-check@main with: package_name: apify_shared + src_package_dir: src/apify_shared + dist_dir: dist + python_version: "3.14" diff --git a/.github/workflows/manual_release_beta.yaml b/.github/workflows/manual_release_beta.yaml index ab59342..3109c34 100644 --- a/.github/workflows/manual_release_beta.yaml +++ b/.github/workflows/manual_release_beta.yaml @@ -64,6 +64,9 @@ jobs: uses: apify/workflows/python-package-check@main with: package_name: apify_shared + src_package_dir: src/apify_shared + dist_dir: dist + python_version: "3.14" # Publish the package to PyPI using PyPA official GitHub action with OIDC authentication. - name: Publish package to PyPI diff --git a/.github/workflows/manual_release_stable.yaml b/.github/workflows/manual_release_stable.yaml index e992171..790aaaa 100644 --- a/.github/workflows/manual_release_stable.yaml +++ b/.github/workflows/manual_release_stable.yaml @@ -99,6 +99,9 @@ jobs: uses: apify/workflows/python-package-check@main with: package_name: apify_shared + src_package_dir: src/apify_shared + dist_dir: dist + python_version: "3.14" # Publishes the package to PyPI using PyPA official GitHub action with OIDC authentication. - name: Publish package to PyPI From 20ddc61dde8c71430f812809122dfdaf72b493b4 Mon Sep 17 00:00:00 2001 From: Vlada Dusek Date: Thu, 14 May 2026 11:15:33 +0200 Subject: [PATCH 3/7] ci: use shared python_package_check workflow from apify/workflows Replaces the local _check_package.yaml with a direct call to the shared reusable workflow. Co-Authored-By: Claude Opus 4.7 (1M context) --- .github/workflows/_check_package.yaml | 32 -------------------------- .github/workflows/on_pull_request.yaml | 5 +++- 2 files changed, 4 insertions(+), 33 deletions(-) delete mode 100644 .github/workflows/_check_package.yaml diff --git a/.github/workflows/_check_package.yaml b/.github/workflows/_check_package.yaml deleted file mode 100644 index 4da77db..0000000 --- a/.github/workflows/_check_package.yaml +++ /dev/null @@ -1,32 +0,0 @@ -name: Package check - -on: - workflow_dispatch: - workflow_call: - -permissions: - contents: read - -jobs: - package_check: - name: Package check - runs-on: ubuntu-latest - steps: - - name: Checkout repository - uses: actions/checkout@v6 - - - name: Set up uv package manager - uses: astral-sh/setup-uv@v8.1.0 - with: - python-version: "3.14" - - - name: Build sdist and wheel - run: uv run poe build - - - name: Verify built package - uses: apify/workflows/python-package-check@main - with: - package_name: apify_shared - src_package_dir: src/apify_shared - dist_dir: dist - python_version: "3.14" diff --git a/.github/workflows/on_pull_request.yaml b/.github/workflows/on_pull_request.yaml index 4660922..3d0c207 100644 --- a/.github/workflows/on_pull_request.yaml +++ b/.github/workflows/on_pull_request.yaml @@ -19,7 +19,10 @@ jobs: package_check: name: Package check - uses: ./.github/workflows/_check_package.yaml + uses: apify/workflows/.github/workflows/python_package_check.yaml@main + with: + package_name: apify_shared + src_package_dir: src/apify_shared tests: name: Tests From c493971179449657f66ce7b6bba99d9a708e309c Mon Sep 17 00:00:00 2001 From: Vlada Dusek Date: Thu, 14 May 2026 11:19:21 +0200 Subject: [PATCH 4/7] ci: pass dist_dir and python_version to shared package check workflow Co-Authored-By: Claude Opus 4.7 (1M context) --- .github/workflows/on_pull_request.yaml | 2 ++ 1 file changed, 2 insertions(+) diff --git a/.github/workflows/on_pull_request.yaml b/.github/workflows/on_pull_request.yaml index 3d0c207..be7e4d0 100644 --- a/.github/workflows/on_pull_request.yaml +++ b/.github/workflows/on_pull_request.yaml @@ -23,6 +23,8 @@ jobs: with: package_name: apify_shared src_package_dir: src/apify_shared + dist_dir: dist + python_version: "3.14" tests: name: Tests From 9fbb83f3235d2162a4a21ec0e67320d1b91ee26e Mon Sep 17 00:00:00 2001 From: Vlada Dusek Date: Thu, 14 May 2026 11:22:15 +0200 Subject: [PATCH 5/7] ci: add a basic smoke check to the python package verification Co-Authored-By: Claude Opus 4.7 (1M context) --- .github/workflows/manual_release_beta.yaml | 2 ++ .github/workflows/manual_release_stable.yaml | 2 ++ .github/workflows/on_pull_request.yaml | 2 ++ 3 files changed, 6 insertions(+) diff --git a/.github/workflows/manual_release_beta.yaml b/.github/workflows/manual_release_beta.yaml index 3109c34..e88827b 100644 --- a/.github/workflows/manual_release_beta.yaml +++ b/.github/workflows/manual_release_beta.yaml @@ -67,6 +67,8 @@ jobs: src_package_dir: src/apify_shared dist_dir: dist python_version: "3.14" + smoke_code: | + from apify_shared.consts import WebhookEventType # Publish the package to PyPI using PyPA official GitHub action with OIDC authentication. - name: Publish package to PyPI diff --git a/.github/workflows/manual_release_stable.yaml b/.github/workflows/manual_release_stable.yaml index 790aaaa..8ee7567 100644 --- a/.github/workflows/manual_release_stable.yaml +++ b/.github/workflows/manual_release_stable.yaml @@ -102,6 +102,8 @@ jobs: src_package_dir: src/apify_shared dist_dir: dist python_version: "3.14" + smoke_code: | + from apify_shared.consts import WebhookEventType # Publishes the package to PyPI using PyPA official GitHub action with OIDC authentication. - name: Publish package to PyPI diff --git a/.github/workflows/on_pull_request.yaml b/.github/workflows/on_pull_request.yaml index be7e4d0..1100c97 100644 --- a/.github/workflows/on_pull_request.yaml +++ b/.github/workflows/on_pull_request.yaml @@ -25,6 +25,8 @@ jobs: src_package_dir: src/apify_shared dist_dir: dist python_version: "3.14" + smoke_code: | + from apify_shared.consts import WebhookEventType tests: name: Tests From 32597a3f27c73288608dcf094277f0aaa0936922 Mon Sep 17 00:00:00 2001 From: Vlada Dusek Date: Thu, 14 May 2026 11:30:12 +0200 Subject: [PATCH 6/7] ci: inline package-check recipe, drop shared reusable workflow indirection Co-Authored-By: Claude Opus 4.7 (1M context) --- .github/workflows/on_pull_request.yaml | 30 +++++++++++++++++++------- 1 file changed, 22 insertions(+), 8 deletions(-) diff --git a/.github/workflows/on_pull_request.yaml b/.github/workflows/on_pull_request.yaml index 1100c97..5821826 100644 --- a/.github/workflows/on_pull_request.yaml +++ b/.github/workflows/on_pull_request.yaml @@ -19,14 +19,28 @@ jobs: package_check: name: Package check - uses: apify/workflows/.github/workflows/python_package_check.yaml@main - with: - package_name: apify_shared - src_package_dir: src/apify_shared - dist_dir: dist - python_version: "3.14" - smoke_code: | - from apify_shared.consts import WebhookEventType + runs-on: ubuntu-latest + steps: + - name: Checkout repository + uses: actions/checkout@v6 + + - name: Set up uv package manager + uses: astral-sh/setup-uv@v8.1.0 + with: + python-version: "3.14" + + - name: Build sdist and wheel + run: uv run poe build + + - name: Verify built package + uses: apify/workflows/python-package-check@main + with: + package_name: apify_shared + src_package_dir: src/apify_shared + dist_dir: dist + python_version: "3.14" + smoke_code: | + from apify_shared.consts import WebhookEventType tests: name: Tests From 7eaa6a02739d6b9a8c164ea51e44b65ae4bb129f Mon Sep 17 00:00:00 2001 From: Vlada Dusek Date: Thu, 14 May 2026 11:38:54 +0200 Subject: [PATCH 7/7] ci: extract package_check job into _check_package.yaml Co-Authored-By: Claude Opus 4.7 (1M context) --- .github/workflows/_check_package.yaml | 37 ++++++++++++++++++++++++++ .github/workflows/on_pull_request.yaml | 23 +--------------- 2 files changed, 38 insertions(+), 22 deletions(-) create mode 100644 .github/workflows/_check_package.yaml diff --git a/.github/workflows/_check_package.yaml b/.github/workflows/_check_package.yaml new file mode 100644 index 0000000..2170880 --- /dev/null +++ b/.github/workflows/_check_package.yaml @@ -0,0 +1,37 @@ +name: Package check + +on: + # Runs when manually triggered from the GitHub UI. + workflow_dispatch: + + # Runs when invoked by another workflow. + workflow_call: + +permissions: + contents: read + +jobs: + package_check: + name: Package check + runs-on: ubuntu-latest + steps: + - name: Checkout repository + uses: actions/checkout@v6 + + - name: Set up uv package manager + uses: astral-sh/setup-uv@v8.1.0 + with: + python-version: "3.14" + + - name: Build sdist and wheel + run: uv run poe build + + - name: Verify built package + uses: apify/workflows/python-package-check@main + with: + package_name: apify_shared + src_package_dir: src/apify_shared + dist_dir: dist + python_version: "3.14" + smoke_code: | + from apify_shared.consts import WebhookEventType diff --git a/.github/workflows/on_pull_request.yaml b/.github/workflows/on_pull_request.yaml index 5821826..4660922 100644 --- a/.github/workflows/on_pull_request.yaml +++ b/.github/workflows/on_pull_request.yaml @@ -19,28 +19,7 @@ jobs: package_check: name: Package check - runs-on: ubuntu-latest - steps: - - name: Checkout repository - uses: actions/checkout@v6 - - - name: Set up uv package manager - uses: astral-sh/setup-uv@v8.1.0 - with: - python-version: "3.14" - - - name: Build sdist and wheel - run: uv run poe build - - - name: Verify built package - uses: apify/workflows/python-package-check@main - with: - package_name: apify_shared - src_package_dir: src/apify_shared - dist_dir: dist - python_version: "3.14" - smoke_code: | - from apify_shared.consts import WebhookEventType + uses: ./.github/workflows/_check_package.yaml tests: name: Tests