From de7028f13a2dffd940021952d5895dc48a85d077 Mon Sep 17 00:00:00 2001 From: Alan Agius <17563226+alan-agius4@users.noreply.github.com> Date: Fri, 27 Feb 2026 14:51:34 +0000 Subject: [PATCH] refactor: remove `tree-kill` dependency by using native `child_process.kill` and correcting `spawn` usage This is no longer required. --- packages/angular_devkit/build_angular/BUILD.bazel | 1 - packages/angular_devkit/build_angular/package.json | 1 - .../build_angular/src/builders/ssr-dev-server/utils.ts | 5 ++--- pnpm-lock.yaml | 3 --- 4 files changed, 2 insertions(+), 8 deletions(-) diff --git a/packages/angular_devkit/build_angular/BUILD.bazel b/packages/angular_devkit/build_angular/BUILD.bazel index b475ebfdf1bc..981e2231e68f 100644 --- a/packages/angular_devkit/build_angular/BUILD.bazel +++ b/packages/angular_devkit/build_angular/BUILD.bazel @@ -154,7 +154,6 @@ ts_project( ":node_modules/source-map-support", ":node_modules/terser", ":node_modules/tinyglobby", - ":node_modules/tree-kill", ":node_modules/webpack", ":node_modules/webpack-dev-middleware", ":node_modules/webpack-dev-server", diff --git a/packages/angular_devkit/build_angular/package.json b/packages/angular_devkit/build_angular/package.json index 00863906a1f5..5872b85511f3 100644 --- a/packages/angular_devkit/build_angular/package.json +++ b/packages/angular_devkit/build_angular/package.json @@ -53,7 +53,6 @@ "source-map-support": "0.5.21", "terser": "5.46.0", "tinyglobby": "0.2.15", - "tree-kill": "1.2.2", "tslib": "2.8.1", "webpack": "5.105.2", "webpack-dev-middleware": "7.4.5", diff --git a/packages/angular_devkit/build_angular/src/builders/ssr-dev-server/utils.ts b/packages/angular_devkit/build_angular/src/builders/ssr-dev-server/utils.ts index db59e2cb6d31..059c0e0a89e9 100644 --- a/packages/angular_devkit/build_angular/src/builders/ssr-dev-server/utils.ts +++ b/packages/angular_devkit/build_angular/src/builders/ssr-dev-server/utils.ts @@ -9,7 +9,6 @@ import { SpawnOptions, spawn } from 'node:child_process'; import { AddressInfo, createConnection, createServer } from 'node:net'; import { Observable, mergeMap, retryWhen, throwError, timer } from 'rxjs'; -import treeKill from 'tree-kill'; export function getAvailablePort(): Promise { return new Promise((resolve, reject) => { @@ -50,8 +49,8 @@ export function spawnAsObservable( }); return () => { - if (!proc.killed && proc.pid) { - treeKill(proc.pid, 'SIGTERM'); + if (!proc.killed) { + proc.kill(); } }; }); diff --git a/pnpm-lock.yaml b/pnpm-lock.yaml index 973c69296503..b74843b5b8b8 100644 --- a/pnpm-lock.yaml +++ b/pnpm-lock.yaml @@ -694,9 +694,6 @@ importers: tinyglobby: specifier: 0.2.15 version: 0.2.15 - tree-kill: - specifier: 1.2.2 - version: 1.2.2 tslib: specifier: 2.8.1 version: 2.8.1