From 41b1f05e4277f563f96d3e757507dd8a2ce664f9 Mon Sep 17 00:00:00 2001 From: PetyaMarkovaBogdanova Date: Wed, 20 May 2026 10:03:13 +0300 Subject: [PATCH 1/2] fix(ui5-list): fix acc findings --- packages/main/src/List.ts | 4 ++++ packages/main/src/ListItemBaseTemplate.tsx | 1 + packages/main/src/ListTemplate.tsx | 2 +- packages/main/src/SelectPopoverTemplate.tsx | 3 ++- 4 files changed, 8 insertions(+), 2 deletions(-) diff --git a/packages/main/src/List.ts b/packages/main/src/List.ts index 2d34da5cefd3..1afc77eaed68 100644 --- a/packages/main/src/List.ts +++ b/packages/main/src/List.ts @@ -840,6 +840,10 @@ class List extends UI5Element { return toLowercaseEnumValue(this.accessibleRole); } + get noDataItemRole() { + return LIST_ACCESSIBLE_ROLE_TO_ITEM_ROLE[this.accessibleRole] || "listitem"; + } + get classes(): ClassMap { return { root: { diff --git a/packages/main/src/ListItemBaseTemplate.tsx b/packages/main/src/ListItemBaseTemplate.tsx index 93726916589a..9a6d5bd78c87 100644 --- a/packages/main/src/ListItemBaseTemplate.tsx +++ b/packages/main/src/ListItemBaseTemplate.tsx @@ -16,6 +16,7 @@ export default function ListItemBaseTemplate(this: ListItemBase, hooks?: { listI draggable={this.movable} role={injectedProps?.role} title={injectedProps?.title} + aria-selected={injectedProps?.role === "option" ? this.selected : undefined} onFocusIn={this._onfocusin} onKeyUp={this._onkeyup} onKeyDown={this._onkeydown} diff --git a/packages/main/src/ListTemplate.tsx b/packages/main/src/ListTemplate.tsx index 1015f60bd72e..7b49be5a7046 100644 --- a/packages/main/src/ListTemplate.tsx +++ b/packages/main/src/ListTemplate.tsx @@ -58,7 +58,7 @@ export default function ListTemplate(this: List) { {this.showNoDataText && -
  • +
  • {this.noDataText}
    diff --git a/packages/main/src/SelectPopoverTemplate.tsx b/packages/main/src/SelectPopoverTemplate.tsx index 6a7626a2ef69..31aef41b9f1e 100644 --- a/packages/main/src/SelectPopoverTemplate.tsx +++ b/packages/main/src/SelectPopoverTemplate.tsx @@ -27,7 +27,7 @@ export default function SelectPopoverTemplate(this: Select) { onBeforeOpen={this._beforeOpen} onClose={this._afterClose} onKeyDown={this._onkeydown} - accessibleName={this._isPhone ? this._headerTitleText : undefined} + accessibleName={this.ariaLabelText || this._headerTitleText} > {this._isPhone &&
    @@ -68,6 +68,7 @@ export default function SelectPopoverTemplate(this: Select) { onMouseDown={this._itemMousedown} onItemClick={this._handleItemPress} accessibleRole="ListBox" + accessibleName={this.ariaLabelText || this._headerTitleText} > From afdefa7ce8340e40d8a867b7a090628b9da0ea74 Mon Sep 17 00:00:00 2001 From: PetyaMarkovaBogdanova Date: Wed, 20 May 2026 10:05:20 +0300 Subject: [PATCH 2/2] fix(ui5-list): fix acc finding --- packages/main/src/List.ts | 4 ++++ packages/main/src/ListItemBaseTemplate.tsx | 1 + packages/main/src/ListTemplate.tsx | 2 +- packages/website/package.json | 3 ++- 4 files changed, 8 insertions(+), 2 deletions(-) diff --git a/packages/main/src/List.ts b/packages/main/src/List.ts index 2d34da5cefd3..1afc77eaed68 100644 --- a/packages/main/src/List.ts +++ b/packages/main/src/List.ts @@ -840,6 +840,10 @@ class List extends UI5Element { return toLowercaseEnumValue(this.accessibleRole); } + get noDataItemRole() { + return LIST_ACCESSIBLE_ROLE_TO_ITEM_ROLE[this.accessibleRole] || "listitem"; + } + get classes(): ClassMap { return { root: { diff --git a/packages/main/src/ListItemBaseTemplate.tsx b/packages/main/src/ListItemBaseTemplate.tsx index 93726916589a..9a6d5bd78c87 100644 --- a/packages/main/src/ListItemBaseTemplate.tsx +++ b/packages/main/src/ListItemBaseTemplate.tsx @@ -16,6 +16,7 @@ export default function ListItemBaseTemplate(this: ListItemBase, hooks?: { listI draggable={this.movable} role={injectedProps?.role} title={injectedProps?.title} + aria-selected={injectedProps?.role === "option" ? this.selected : undefined} onFocusIn={this._onfocusin} onKeyUp={this._onkeyup} onKeyDown={this._onkeydown} diff --git a/packages/main/src/ListTemplate.tsx b/packages/main/src/ListTemplate.tsx index 1015f60bd72e..7b49be5a7046 100644 --- a/packages/main/src/ListTemplate.tsx +++ b/packages/main/src/ListTemplate.tsx @@ -58,7 +58,7 @@ export default function ListTemplate(this: List) { {this.showNoDataText && -
  • +
  • {this.noDataText}
    diff --git a/packages/website/package.json b/packages/website/package.json index f2fcdd398469..fdb8dd0ff8f6 100644 --- a/packages/website/package.json +++ b/packages/website/package.json @@ -10,7 +10,7 @@ "generate-illustrations": "rimraf ./illustrations && rimraf ./illustrations-tnt && node ./build-scripts/illustrations-generation/index.mjs", "generate-llms-txt": "node ./build-scripts/llms-txt-generation/index.mjs", "generate-local-env": "yarn generate-api-reference && yarn generate-documentation && yarn generate-icons && yarn generate-illustrations && yarn generate-llms-txt", - "generate-production-env": "yarn generate-local-env && rimraf ./static/pages && rimraf ./static/assets && yarn copy:pages:compat && yarn copy:pages:ai && yarn copy:pages:fiori && yarn copy:pages:main", + "generate-production-env": "yarn generate-local-env && rimraf ./static/pages && rimraf ./static/assets && yarn copy:pages:compat && yarn copy:pages:ai && yarn copy:pages:fiori && yarn copy:pages:base && yarn copy:pages:main", "docusaurus": "docusaurus", "start": "yarn generate-local-cdn && yarn generate-local-env && docusaurus start", "build": "yarn generate-production-env && docusaurus build", @@ -19,6 +19,7 @@ "copy:pages:ai": "copy-and-watch \"../ai/dist/assets/**/*\" \"./static/assets/\" && copy-and-watch \"../ai/dist/test/pages/**/*\" \"./static/packages/ai/test/pages/\"", "copy:pages:main": "copy-and-watch \"../main/dist/assets/**/*\" \"./static/assets/\" && copy-and-watch \"../main/dist/test/pages/**/*\" \"./static/packages/main/test/pages/\"", "copy:pages:fiori": "copy-and-watch \"../fiori/dist/assets/**/*\" \"./static/assets/\" && copy-and-watch \"../fiori/dist/test/pages/**/*\" \"./static/packages/fiori/test/pages/\"", + "copy:pages:base": "copy-and-watch \"../base/dist/assets/**/*\" \"./static/assets/\" && copy-and-watch \"../base/dist/test/pages/**/*\" \"./static/packages/base/test/pages/\"", "swizzle": "docusaurus swizzle", "deploy": "docusaurus deploy", "clear": "docusaurus clear",