From 118d1d75843c39d2ddebaa4a25b92090ba042e7d Mon Sep 17 00:00:00 2001 From: PetyaMarkovaBogdanova Date: Wed, 20 May 2026 09:55:29 +0300 Subject: [PATCH] fix(ui5-shellbar): fix acc finding --- packages/fiori/src/ShellBar.ts | 1 + packages/fiori/src/ShellBarTemplate.tsx | 1 + packages/fiori/src/shellbar/ShellBarAccessibility.ts | 4 +++- .../src/shellbar/templates/ShellBarSearchLegacyTemplate.tsx | 1 - 4 files changed, 5 insertions(+), 2 deletions(-) diff --git a/packages/fiori/src/ShellBar.ts b/packages/fiori/src/ShellBar.ts index 6c95b88b8a07..02d65270699a 100644 --- a/packages/fiori/src/ShellBar.ts +++ b/packages/fiori/src/ShellBar.ts @@ -1074,6 +1074,7 @@ class ShellBar extends UI5Element { return this.accessibility.getActionsAccessibilityAttributes(this.texts, { overflowPopoverOpen: this.overflowPopoverOpen, accessibilityAttributes: this.accessibilityAttributes, + showSearchField: this.showSearchField, }); } diff --git a/packages/fiori/src/ShellBarTemplate.tsx b/packages/fiori/src/ShellBarTemplate.tsx index 885e03aae131..b8f9ae866807 100644 --- a/packages/fiori/src/ShellBarTemplate.tsx +++ b/packages/fiori/src/ShellBarTemplate.tsx @@ -234,6 +234,7 @@ export default function ShellBarTemplate(this: ShellBar) { placement="Bottom" hideArrow={true} horizontalAlign={this.popoverHorizontalAlign} // TODO: add test + accessibleName={actionsAccInfo.overflow.title} > {this.overflowItems.map(item => { diff --git a/packages/fiori/src/shellbar/ShellBarAccessibility.ts b/packages/fiori/src/shellbar/ShellBarAccessibility.ts index 4c042ff80634..90b8e8c37fae 100644 --- a/packages/fiori/src/shellbar/ShellBarAccessibility.ts +++ b/packages/fiori/src/shellbar/ShellBarAccessibility.ts @@ -43,9 +43,10 @@ class ShellBarAccessibility { params: { accessibilityAttributes: ShellBarAccessibilityAttributes; overflowPopoverOpen: boolean; + showSearchField: boolean; }, ): ShellBarAccessibilityInfo { - const { overflowPopoverOpen, accessibilityAttributes } = params; + const { overflowPopoverOpen, accessibilityAttributes, showSearchField } = params; const overflowExpanded = accessibilityAttributes.overflow?.expanded; return { @@ -74,6 +75,7 @@ class ShellBarAccessibility { title: defaultTexts.search, accessibilityAttributes: { hasPopup: accessibilityAttributes.search?.hasPopup, + expanded: accessibilityAttributes.search?.expanded !== undefined ? accessibilityAttributes.search.expanded : showSearchField, }, }, overflow: { diff --git a/packages/fiori/src/shellbar/templates/ShellBarSearchLegacyTemplate.tsx b/packages/fiori/src/shellbar/templates/ShellBarSearchLegacyTemplate.tsx index ab27a656ec6c..b90f09275d05 100644 --- a/packages/fiori/src/shellbar/templates/ShellBarSearchLegacyTemplate.tsx +++ b/packages/fiori/src/shellbar/templates/ShellBarSearchLegacyTemplate.tsx @@ -45,7 +45,6 @@ function ShellBarSearchButton(this: ShellBar) { design="Transparent" onClick={this.handleSearchButtonClick} tooltip={this.actionsAccessibilityInfo.search.title} - aria-expanded={this.showSearchField} accessibilityAttributes={this.actionsAccessibilityInfo.search.accessibilityAttributes} /> )}