Skip to content

Commit ca4cbca

Browse files
committed
Merge branch 'preview'
2 parents 48f380e + 30d3ee8 commit ca4cbca

1 file changed

Lines changed: 15 additions & 7 deletions

File tree

assets/scss/_home.scss

Lines changed: 15 additions & 7 deletions
Original file line numberDiff line numberDiff line change
@@ -77,9 +77,16 @@ $collapse-function: ease-out;
7777
display: grid;
7878
grid-template-rows: 1fr;
7979
transition: all $collapse-time $collapse-function;
80-
& > * {
81-
overflow: hidden;
82-
}
80+
81+
// Overflow hidden does not fit my use case because there is a visual clip with the tag glow effect;
82+
// and if I were to set overflow hidden ONLY on the collapsed state, the entire visual transition will clip which does not look nice.
83+
// Instead of using `overflow: hidden` here, I use a weird max-height hack.
84+
// Setting it to 1px works here because the metadata tag container is only one part of the box being expanded.
85+
// Other than the tag box, the post description will also be expanded, so the tag container "races" it.
86+
max-height: 1px;
87+
// & > * {
88+
// overflow: hidden;
89+
// }
8390
}
8491
}
8592

@@ -129,7 +136,7 @@ $collapse-function: ease-out;
129136
display: grid;
130137
grid-template-rows: 1fr;
131138
transition: all $collapse-time $collapse-function;
132-
139+
133140
& > * {
134141
overflow: hidden;
135142
}
@@ -196,9 +203,6 @@ $collapse-function: ease-out;
196203
align-items: center;
197204
// grid-template-rows: 1fr;
198205
transition: all $collapse-time $collapse-function;
199-
& > * {
200-
overflow: hidden;
201-
}
202206
}
203207
}
204208

@@ -281,6 +285,10 @@ $collapse-function: ease-out;
281285
.metadata-tag-container {
282286
opacity: 0;
283287
grid-template-rows: 0fr;
288+
max-height: 0;
289+
// & > * {
290+
// overflow: hidden;
291+
// }
284292
}
285293

286294
.post-preview-metadata-container {

0 commit comments

Comments
 (0)