Skip to content

Commit adf5a4f

Browse files
authored
Update AGENTS.md with review guidelines (prebid#14612)
Added review guidelines for PR reviews and module rules. Work in progress
1 parent 51e5602 commit adf5a4f

1 file changed

Lines changed: 11 additions & 0 deletions

File tree

AGENTS.md

Lines changed: 11 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -58,3 +58,14 @@ This file contains instructions for the Codex agent and its friends when working
5858
- Prefer importing or mirroring conventions from these modules instead of redefining local ad-hoc shapes.
5959
- Use imported types for id, analytics, and rtd modules as well whenever possible.
6060
- Always define types for public interface to an adapter, eg each bidder parameter.
61+
62+
## Review guidelines
63+
- Use the guidelines at PR_REVIEW.md when doing PR reviews. Make all your comments and code suggestions on the PR itself instead of in linked tasks when commenting in a PR review.
64+
- Use the module rules at https://docs.prebid.org/dev-docs/module-rules.html
65+
- Discourage application/json calls, they cause preflight options calls with induced delays over text/plain
66+
- Make sure people are importing from libraries and our methods whenever possible, eg on viewability or accessing navigator
67+
- Bidder params should always only override that information coming on the request; bidders should never make someone specify something that is generally available in an ortb2 field on the request in bidder params unless they need an override.
68+
- Bidders asking for storage access and setting an id in local storage redundant with the shared id is discouraged, they should document why they need to do this odious behavior
69+
- Submodules need to register in submodules.json
70+
- No one should be accessing navigator from vendor modules, if navigator needs to be accessed it should be in a common method or library
71+
- Low priority calls should be import ajax method and use fetch keepalive; they shouldnt use trigger pixel when it can be avoided or fail to specify keepalive.

0 commit comments

Comments
 (0)