fix: $global scanner config correctly inherited by per-repo entries#77
Open
Valyrian-Code wants to merge 1 commit into
Open
fix: $global scanner config correctly inherited by per-repo entries#77Valyrian-Code wants to merge 1 commit into
Valyrian-Code wants to merge 1 commit into
Conversation
semgrep, trufflehog, claude, and piAgent blocks were merged from DEFAULT_CONFIG + per-repo overrides only — globalConfig was extracted but never spread into the scanner merges. trigger and comment handled this correctly; scanner blocks did not. Adds two tests covering global inheritance and per-repo override precedence for semgrep.
3 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
semgrep,trufflehog,claude,piAgent) in$globalwere silently ignored when building per-repo configs. The merge chain wasDEFAULT_CONFIG → repoOverrides, skipping the global layer entirely.globalConfigas the middle layer for all four scanner blocks, matching the pattern already used fortriggerandcomment.Root cause
src/config.tslines 98-101 spread only default and repo-override, never global:Test plan
$global.semgrep.extraArgsis inherited when repo has no semgrep blocknpm test— 635 tests, 0 failures