From 68acc50ecccbca75cfc7290a3b36cb4b87d63c55 Mon Sep 17 00:00:00 2001 From: Siim Raud Date: Thu, 26 Mar 2026 15:46:30 +0200 Subject: [PATCH] fix: replace Promise with SuccessResponse in line mutation functions All six line mutation functions (update, enable, disable, archive, unarchive, deleteLine) returned Promise, undermining type safety for consumers. Replaced with Promise to match the existing pattern used in user.ts. --- .../src/lib/services/line/line.ts | 26 +++++++++---------- 1 file changed, 13 insertions(+), 13 deletions(-) diff --git a/packages/javascript-api/src/lib/services/line/line.ts b/packages/javascript-api/src/lib/services/line/line.ts index 42e097d9..b167fdfb 100644 --- a/packages/javascript-api/src/lib/services/line/line.ts +++ b/packages/javascript-api/src/lib/services/line/line.ts @@ -1,7 +1,7 @@ import { Line } from '../../model/line.js'; import { Location } from '../../model/location.js'; import { extractId, IdOrObject } from '../../util/id-or-object.js'; -import { ApiBase } from '../api-base/api-base.js'; +import { ApiBase, SuccessResponse } from '../api-base/api-base.js'; type LineCreateParameters = Partial> & Pick; type LineUpdateParameters = Pick & @@ -45,7 +45,7 @@ export function create( }) as Promise; } -export function update(line: LineUpdateParameters): Promise { +export function update(line: LineUpdateParameters): Promise { if (!line || typeof line !== 'object') { throw new Error('Line is invalid or missing.'); } @@ -69,40 +69,40 @@ export function update(line: LineUpdateParameters): Promise { return ApiBase.request(`v1/lines/${lineId}`, { body: data, method: 'POST', - }) as Promise; + }) as Promise; } -export function enable(line: IdOrObject): Promise { +export function enable(line: IdOrObject): Promise { const lineId = extractId(line); if (!lineId || typeof lineId !== 'string') { throw new Error('Line ID invalid or missing.'); } return ApiBase.request(`v1/lines/${lineId}/enable`, { method: 'POST', - }) as Promise; + }) as Promise; } -export function disable(line: IdOrObject): Promise { +export function disable(line: IdOrObject): Promise { const lineId = extractId(line); if (!lineId || typeof lineId !== 'string') { throw new Error('Line ID invalid or missing.'); } return ApiBase.request(`v1/lines/${lineId}/disable`, { method: 'POST', - }) as Promise; + }) as Promise; } -export function archive(line: IdOrObject): Promise { +export function archive(line: IdOrObject): Promise { const lineId = extractId(line); if (!lineId || typeof lineId !== 'string') { throw new Error('Line ID invalid or missing.'); } return ApiBase.request(`v1/lines/${lineId}/archive`, { method: 'POST', - }) as Promise; + }) as Promise; } -export function unarchive(line: IdOrObject): Promise { +export function unarchive(line: IdOrObject): Promise { const lineId = extractId(line); if (!lineId || typeof lineId !== 'string') { @@ -110,10 +110,10 @@ export function unarchive(line: IdOrObject): Promise { } return ApiBase.request(`v1/lines/${lineId}/unarchive`, { method: 'POST', - }) as Promise; + }) as Promise; } -export function deleteLine(line: IdOrObject): Promise { +export function deleteLine(line: IdOrObject): Promise { const lineId = extractId(line); if (!lineId || typeof lineId !== 'string') { @@ -121,5 +121,5 @@ export function deleteLine(line: IdOrObject): Promise { } return ApiBase.request(`v1/lines/${lineId}`, { method: 'DELETE', - }) as Promise; + }) as Promise; }