Skip to content

Commit 753f975

Browse files
committed
fix: address PR review feedback for createInputField
Remove duplicate JSDoc from implementation function, remove V2 header implementation detail from service docs, and remove internal InputFieldBase from public API exports.
1 parent b3e3565 commit 753f975

3 files changed

Lines changed: 1 addition & 10 deletions

File tree

packages/javascript-api/src/lib/services/location/location.service.ts

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -99,7 +99,7 @@ export const LocationService = {
9999
/**
100100
* Create a new input field for a location.
101101
*
102-
* Calls the following HTTP API: `POST /input-fields` (with V2 header)
102+
* Calls the following HTTP API: `POST /input-fields`
103103
*/
104104
createInputField,
105105
};

packages/javascript-api/src/lib/services/location/location.ts

Lines changed: 0 additions & 8 deletions
Original file line numberDiff line numberDiff line change
@@ -56,14 +56,6 @@ export async function setOpeningHoursExceptions(
5656
});
5757
}
5858

59-
/**
60-
* Create a new input field for a location.
61-
*
62-
* Calls the following HTTP API: `POST /input-fields` (with V2 header)
63-
*
64-
* @param inputField the input field creation request
65-
* @returns a promise that resolves when the input field has been created
66-
*/
6759
export async function createInputField(
6860
inputField: InputFieldCreationRequest,
6961
): Promise<void> {

packages/javascript-api/src/public-api/model.ts

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -35,7 +35,6 @@ export { TicketLabelRequest } from '../lib/model/ticket/ticket-label-request.js'
3535
export { TicketType } from '../lib/model/ticket/ticket-type.js';
3636
export { UUID } from '../lib/model/uuid.js';
3737
export { InputFieldCreationRequest } from '../lib/model/input-field/input-field-creation-request.js';
38-
export { InputFieldBase } from '../lib/model/input-field/input-field-base.js';
3938
export { LocationRef } from '../lib/model/input-field/location-ref.js';
4039
export { LineRef } from '../lib/model/input-field/line-ref.js';
4140
export { InputFieldTranslation } from '../lib/model/input-field/input-field-translation.js';

0 commit comments

Comments
 (0)