Spinning Issue

[Cavinaar]

MechJeb Version

The version I am having issues with is 2.15.1.0

KSP Version

1.12.5.190

Description

The current version leaves the rocket either rotating in the roll vector or spinning in the pitch vector. Ascent guidance, rendezvous autopilot, maneuver planner, rendezvous planner all seem to do it. Rendezvous planner seems to do it more often, though.

Replication Case

https://youtu.be/wZuaLSJp-yE?si=QJ-gCVZo7ULOl69S

KSP.log

NOTE: The latest development release of MechJeb can be downloaded from jenkins ( https://tinyurl.com/hgckqmk ).

[lamont-granquist]

Probably related to #2028, at some point roll was ignored in the node executor due to spin-stabilized rockets in RealismOverhaul.

[lamont-granquist]

Might actually date back to #1792

[lamont-granquist]

(offhand I don't know how to fix this short of adding yet another button to push)

[Cavinaar]

I rolled back to 2.14.3.0 and it stopped happening.

I don't know if that helps or not.

[Cavinaar]

Also, not everyone runs with the same mods. I don't use Realism Overhaul for example.

[lamont-granquist]

Yeah, that's the problem with trying to keep everyone happy and not break anyone. One person's bugfix is another person's bug.

[Cavinaar]

I can definitely understand the frustration, especially when it is being done on a volunteer basis.

Perhaps add a selection in the settings to indicate whether or not you have realism overhaul?

I don't know, just throwing something out there.

[Nazfib]

With #2028, the maneuver executor now starts timewarp even when the craft is stil spinning around its roll axis. In stock (without Persistent Rotation, RO, Principia or another mod that keeps rotation during timewarp), that should kill the roll motion. This PR is not yet in the latest release, though.

A 'force roll' or 'damp roll rate' toggle in the maneuver executor might still be nice, though; defaulted to enabled without RO, disabled when RO is detected.

[lamont-granquist]

I think the behavior here is that if the maneuver node isn't far enough in the future to timewarp, that it doesn't killrot via the timewarp even in stock.

So there likely does need to be a switch. I'm kind of thinking it should be something like "Kill Rotation"? Or something like that to be consistent and really simple and obvious? Then have it default to on, and do that with one commit.

Then another commit could happen to switch the default with RO to false using the ApplyRODefaults() hook.

[Cavinaar]

There is a 'kill rotation' already in Smart A.S.S.

[lamont-granquist]

fixed by #2094

[Begus001]

#2094 doesn't address rotation occurring in other modes, e.g. Landing Guidance and Ascent Guidance, does it? It'd be nice to have a toggle in Utilities for example to be able to always kill the rotation if you don't want it to rotate to a specific angle but just stop rotating.