Skip to content

[JitDiff X64] [MihaZupan] JIT: Use faster mod for uint16 values #1933

@MihuBot

Description

@MihuBot

Job completed in 3 minutes 59 seconds (remote runner delay: 0 seconds).
dotnet/runtime#128509

Main commit: dotnet/runtime@7da2acb
PR commit: MihaZupan/runtime@897296a

Diffs

Found 86 files with textual diffs.

Summary of Code Size diffs:
(Lower is better)

Total bytes of base: 46473075
Total bytes of diff: 46472962
Total bytes of delta: -113 (-0.00 % of base)
Total relative delta: -0.11
    diff is an improvement.
    relative diff is an improvement.


Top file improvements (bytes):
         -46 : System.Private.CoreLib.dasm (-0.00 % of base)
         -30 : System.Runtime.Numerics.dasm (-0.02 % of base)
         -27 : System.Text.Encoding.CodePages.dasm (-0.04 % of base)
         -10 : System.Data.Odbc.dasm (-0.00 % of base)

4 total files with Code Size differences (4 improved, 0 regressed), 256 unchanged.

Top method improvements (bytes):
         -27 (-1.19 % of base) : System.Text.Encoding.CodePages.dasm - System.Text.GB18030Encoding:GetBytes(ptr,int,ptr,int,System.Text.EncoderNLS):int:this (FullOpts)
         -26 (-1.87 % of base) : System.Runtime.Numerics.dasm - System.Numerics.BigInteger:TryGetBytes(int,System.Span`1[byte],bool,bool,byref):byte[]:this (FullOpts)
         -18 (-1.17 % of base) : System.Private.CoreLib.dasm - System.Globalization.DateTimeFormatInfo:Tokenize(int,byref,byref,byref):bool:this (FullOpts)
         -13 (-0.53 % of base) : System.Private.CoreLib.dasm - System.Number:FormatFloatingPointAsHex[double,byte](byref,double,char,int,System.Globalization.NumberFormatInfo) (FullOpts)
         -11 (-1.12 % of base) : System.Private.CoreLib.dasm - System.Globalization.DateTimeFormatInfo:InsertHash(System.Globalization.DateTimeFormatInfo+TokenHashValue[],System.String,int,int):this (FullOpts)
          -6 (-1.22 % of base) : System.Data.Odbc.dasm - System.Data.ProviderBase.DbBuffer:ReadDateTime(int):System.DateTime:this (FullOpts)
          -4 (-1.45 % of base) : System.Data.Odbc.dasm - System.Data.ProviderBase.DbBuffer:ReadDate(int):System.DateTime:this (FullOpts)
          -4 (-0.81 % of base) : System.Private.CoreLib.dasm - System.Diagnostics.Tracing.EventSource:SendManifest(byte[]):this (FullOpts)
          -1 (-0.58 % of base) : System.Runtime.Numerics.dasm - System.Numerics.BigInteger:GetBitLength():long:this (FullOpts)
          -1 (-0.56 % of base) : System.Runtime.Numerics.dasm - System.Numerics.BigInteger:Log2(System.Numerics.BigInteger):System.Numerics.BigInteger (FullOpts)
          -1 (-0.32 % of base) : System.Runtime.Numerics.dasm - System.Numerics.BigInteger:PopCount(System.Numerics.BigInteger):System.Numerics.BigInteger (FullOpts)
          -1 (-0.54 % of base) : System.Runtime.Numerics.dasm - System.Numerics.BigInteger:TrailingZeroCount(System.Numerics.BigInteger):System.Numerics.BigInteger (FullOpts)

Top method improvements (percentages):
         -26 (-1.87 % of base) : System.Runtime.Numerics.dasm - System.Numerics.BigInteger:TryGetBytes(int,System.Span`1[byte],bool,bool,byref):byte[]:this (FullOpts)
          -4 (-1.45 % of base) : System.Data.Odbc.dasm - System.Data.ProviderBase.DbBuffer:ReadDate(int):System.DateTime:this (FullOpts)
          -6 (-1.22 % of base) : System.Data.Odbc.dasm - System.Data.ProviderBase.DbBuffer:ReadDateTime(int):System.DateTime:this (FullOpts)
         -27 (-1.19 % of base) : System.Text.Encoding.CodePages.dasm - System.Text.GB18030Encoding:GetBytes(ptr,int,ptr,int,System.Text.EncoderNLS):int:this (FullOpts)
         -18 (-1.17 % of base) : System.Private.CoreLib.dasm - System.Globalization.DateTimeFormatInfo:Tokenize(int,byref,byref,byref):bool:this (FullOpts)
         -11 (-1.12 % of base) : System.Private.CoreLib.dasm - System.Globalization.DateTimeFormatInfo:InsertHash(System.Globalization.DateTimeFormatInfo+TokenHashValue[],System.String,int,int):this (FullOpts)
          -4 (-0.81 % of base) : System.Private.CoreLib.dasm - System.Diagnostics.Tracing.EventSource:SendManifest(byte[]):this (FullOpts)
          -1 (-0.58 % of base) : System.Runtime.Numerics.dasm - System.Numerics.BigInteger:GetBitLength():long:this (FullOpts)
          -1 (-0.56 % of base) : System.Runtime.Numerics.dasm - System.Numerics.BigInteger:Log2(System.Numerics.BigInteger):System.Numerics.BigInteger (FullOpts)
          -1 (-0.54 % of base) : System.Runtime.Numerics.dasm - System.Numerics.BigInteger:TrailingZeroCount(System.Numerics.BigInteger):System.Numerics.BigInteger (FullOpts)
         -13 (-0.53 % of base) : System.Private.CoreLib.dasm - System.Number:FormatFloatingPointAsHex[double,byte](byref,double,char,int,System.Globalization.NumberFormatInfo) (FullOpts)
          -1 (-0.32 % of base) : System.Runtime.Numerics.dasm - System.Numerics.BigInteger:PopCount(System.Numerics.BigInteger):System.Numerics.BigInteger (FullOpts)

12 total methods with Code Size differences (12 improved, 0 regressed), 288429 unchanged.

--------------------------------------------------------------------------------

Artifacts:

Metadata

Metadata

Assignees

No one assigned

    Labels

    No labels
    No labels

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions