Skip to content

[JitDiff X64] [MihaZupan] JIT: Use faster mod for uint16 values #1924

@MihuBot

Description

@MihuBot

Job completed in 7 minutes 24 seconds (remote runner delay: 0 seconds).
dotnet/runtime#128509

Main commit: dotnet/runtime@070886d
PR commit: MihaZupan/runtime@cea3809

Diffs

Found 87 files with textual diffs.

Summary of Code Size diffs:
(Lower is better)

Total bytes of base: 46473989
Total bytes of diff: 46473976
Total bytes of delta: -13 (-0.00 % of base)
Total relative delta: Infinity
    diff is an improvement.
    relative diff is a regression.


Top file regressions (bytes):
         109 : System.DirectoryServices.Protocols.dasm (0.07 % of base)

Top file improvements (bytes):
         -55 : System.Private.CoreLib.dasm (-0.00 % of base)
         -30 : System.Runtime.Numerics.dasm (-0.02 % of base)
         -27 : System.Text.Encoding.CodePages.dasm (-0.04 % of base)
         -10 : System.Data.Odbc.dasm (-0.00 % of base)

5 total files with Code Size differences (4 improved, 1 regressed), 255 unchanged.

Top method regressions (bytes):
         109 (Infinity of base) : System.DirectoryServices.Protocols.dasm - System.DirectoryServices.Protocols.PartialResultsRetriever:ThreadRoutine():this (FullOpts)

Top method improvements (bytes):
         -27 (-1.19 % of base) : System.Text.Encoding.CodePages.dasm - System.Text.GB18030Encoding:GetBytes(ptr,int,ptr,int,System.Text.EncoderNLS):int:this (FullOpts)
         -26 (-1.87 % of base) : System.Runtime.Numerics.dasm - System.Numerics.BigInteger:TryGetBytes(int,System.Span`1[byte],bool,bool,byref):byte[]:this (FullOpts)
         -18 (-1.17 % of base) : System.Private.CoreLib.dasm - System.Globalization.DateTimeFormatInfo:Tokenize(int,byref,byref,byref):bool:this (FullOpts)
         -13 (-0.53 % of base) : System.Private.CoreLib.dasm - System.Number:FormatFloatingPointAsHex[double,byte](byref,double,char,int,System.Globalization.NumberFormatInfo) (FullOpts)
         -11 (-1.12 % of base) : System.Private.CoreLib.dasm - System.Globalization.DateTimeFormatInfo:InsertHash(System.Globalization.DateTimeFormatInfo+TokenHashValue[],System.String,int,int):this (FullOpts)
          -6 (-1.22 % of base) : System.Data.Odbc.dasm - System.Data.ProviderBase.DbBuffer:ReadDateTime(int):System.DateTime:this (FullOpts)
          -4 (-1.45 % of base) : System.Data.Odbc.dasm - System.Data.ProviderBase.DbBuffer:ReadDate(int):System.DateTime:this (FullOpts)
          -4 (-0.81 % of base) : System.Private.CoreLib.dasm - System.Diagnostics.Tracing.EventSource:SendManifest(byte[]):this (FullOpts)
          -3 (-0.62 % of base) : System.Private.CoreLib.dasm - System.Int128:System.Numerics.IBinaryInteger<System.Int128>.TryReadLittleEndian(System.ReadOnlySpan`1[byte],bool,byref):bool (FullOpts)
          -3 (-1.44 % of base) : System.Private.CoreLib.dasm - System.SByte:System.Numerics.IBinaryInteger<System.SByte>.TryReadBigEndian(System.ReadOnlySpan`1[byte],bool,byref):bool (FullOpts)
          -3 (-1.96 % of base) : System.Private.CoreLib.dasm - System.SByte:System.Numerics.IBinaryInteger<System.SByte>.TryReadLittleEndian(System.ReadOnlySpan`1[byte],bool,byref):bool (FullOpts)
          -1 (-0.58 % of base) : System.Runtime.Numerics.dasm - System.Numerics.BigInteger:GetBitLength():long:this (FullOpts)
          -1 (-0.56 % of base) : System.Runtime.Numerics.dasm - System.Numerics.BigInteger:Log2(System.Numerics.BigInteger):System.Numerics.BigInteger (FullOpts)
          -1 (-0.32 % of base) : System.Runtime.Numerics.dasm - System.Numerics.BigInteger:PopCount(System.Numerics.BigInteger):System.Numerics.BigInteger (FullOpts)
          -1 (-0.54 % of base) : System.Runtime.Numerics.dasm - System.Numerics.BigInteger:TrailingZeroCount(System.Numerics.BigInteger):System.Numerics.BigInteger (FullOpts)

Top method regressions (percentages):
         109 (Infinity of base) : System.DirectoryServices.Protocols.dasm - System.DirectoryServices.Protocols.PartialResultsRetriever:ThreadRoutine():this (FullOpts)

Top method improvements (percentages):
          -3 (-1.96 % of base) : System.Private.CoreLib.dasm - System.SByte:System.Numerics.IBinaryInteger<System.SByte>.TryReadLittleEndian(System.ReadOnlySpan`1[byte],bool,byref):bool (FullOpts)
         -26 (-1.87 % of base) : System.Runtime.Numerics.dasm - System.Numerics.BigInteger:TryGetBytes(int,System.Span`1[byte],bool,bool,byref):byte[]:this (FullOpts)
          -4 (-1.45 % of base) : System.Data.Odbc.dasm - System.Data.ProviderBase.DbBuffer:ReadDate(int):System.DateTime:this (FullOpts)
          -3 (-1.44 % of base) : System.Private.CoreLib.dasm - System.SByte:System.Numerics.IBinaryInteger<System.SByte>.TryReadBigEndian(System.ReadOnlySpan`1[byte],bool,byref):bool (FullOpts)
          -6 (-1.22 % of base) : System.Data.Odbc.dasm - System.Data.ProviderBase.DbBuffer:ReadDateTime(int):System.DateTime:this (FullOpts)
         -27 (-1.19 % of base) : System.Text.Encoding.CodePages.dasm - System.Text.GB18030Encoding:GetBytes(ptr,int,ptr,int,System.Text.EncoderNLS):int:this (FullOpts)
         -18 (-1.17 % of base) : System.Private.CoreLib.dasm - System.Globalization.DateTimeFormatInfo:Tokenize(int,byref,byref,byref):bool:this (FullOpts)
         -11 (-1.12 % of base) : System.Private.CoreLib.dasm - System.Globalization.DateTimeFormatInfo:InsertHash(System.Globalization.DateTimeFormatInfo+TokenHashValue[],System.String,int,int):this (FullOpts)
          -4 (-0.81 % of base) : System.Private.CoreLib.dasm - System.Diagnostics.Tracing.EventSource:SendManifest(byte[]):this (FullOpts)
          -3 (-0.62 % of base) : System.Private.CoreLib.dasm - System.Int128:System.Numerics.IBinaryInteger<System.Int128>.TryReadLittleEndian(System.ReadOnlySpan`1[byte],bool,byref):bool (FullOpts)
          -1 (-0.58 % of base) : System.Runtime.Numerics.dasm - System.Numerics.BigInteger:GetBitLength():long:this (FullOpts)
          -1 (-0.56 % of base) : System.Runtime.Numerics.dasm - System.Numerics.BigInteger:Log2(System.Numerics.BigInteger):System.Numerics.BigInteger (FullOpts)
          -1 (-0.54 % of base) : System.Runtime.Numerics.dasm - System.Numerics.BigInteger:TrailingZeroCount(System.Numerics.BigInteger):System.Numerics.BigInteger (FullOpts)
         -13 (-0.53 % of base) : System.Private.CoreLib.dasm - System.Number:FormatFloatingPointAsHex[double,byte](byref,double,char,int,System.Globalization.NumberFormatInfo) (FullOpts)
          -1 (-0.32 % of base) : System.Runtime.Numerics.dasm - System.Numerics.BigInteger:PopCount(System.Numerics.BigInteger):System.Numerics.BigInteger (FullOpts)

16 total methods with Code Size differences (15 improved, 1 regressed), 288425 unchanged.

--------------------------------------------------------------------------------

Artifacts:

Metadata

Metadata

Assignees

No one assigned

    Labels

    No labels
    No labels

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions