Skip to content

Commit f5ca56e

Browse files
authored
Handle invalid request ID in HDRLQuerySchema (#244)
1 parent 78343d8 commit f5ca56e

File tree

1 file changed

+9
-1
lines changed

1 file changed

+9
-1
lines changed

hdrl/src/org/labkey/hdrl/query/HDRLQuerySchema.java

Lines changed: 9 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -19,6 +19,7 @@
1919
import org.apache.commons.lang3.StringUtils;
2020
import org.jetbrains.annotations.NotNull;
2121
import org.jetbrains.annotations.Nullable;
22+
import org.labkey.api.action.ApiUsageException;
2223
import org.labkey.api.data.Container;
2324
import org.labkey.api.data.ContainerFilter;
2425
import org.labkey.api.data.ContainerManager;
@@ -235,7 +236,14 @@ else if (TABLE_INBOUND_SPECIMEN.equalsIgnoreCase(settings.getQueryName()) || TAB
235236
SimpleFilter baseFilter = settings.getBaseFilter();
236237
if (StringUtils.isNotBlank(requestId))
237238
{
238-
baseFilter.addAllClauses(new SimpleFilter(FieldKey.fromParts("inboundRequestId"), Integer.valueOf(requestId)));
239+
try
240+
{
241+
baseFilter.addAllClauses(new SimpleFilter(FieldKey.fromParts("inboundRequestId"), Integer.valueOf(requestId)));
242+
}
243+
catch (NumberFormatException e)
244+
{
245+
throw new ApiUsageException("Invalid request id");
246+
}
239247
}
240248

241249
QueryView queryView = new QueryView(this, settings, errors)

0 commit comments

Comments
 (0)