Fix cache concurrency#1
Open
Xcelled wants to merge 2 commits into
Open
Conversation
|
LGTM Are there any unit tests we could add to verify the fixed concurrency? |
suruuK
reviewed
May 20, 2024
|
|
||
| try { | ||
| // Atomically rename the completed cache entry into place | ||
| Files.move(tempDirectory, target.toPath(), StandardCopyOption.ATOMIC_MOVE); |
There was a problem hiding this comment.
should we catch and have an alternative for fs's that dont support atomic move ?
|
would you consider submitting a PR upstream for these fixes? |
Author
Yes! I've been testing and fine-tuning these changes a little more internally first. Once they're ready I'll open a PR against the upstream. Might be ready tomorrow, might be Friday. |
Xcelled
force-pushed
the
fix-cache-concurrency
branch
from
3bad684 to
e754307
Compare
Xcelled
force-pushed
the
fix-cache-concurrency
branch
from
e754307 to
46ae8a2
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The existing implementation used marker files and had some flaws that we found at scale, notably:
I changed the implementation to instead first copy into a temporary sibling folder and then atomically rename the temp folder to the expected cache key.
As part of this, the behavior changed to not update the cache once an entry is cached; this seems to me to be the safest and most desirable but it went against a test I removed, so I'm open to hearing otherwise.
@stevie400 @jaredstehler @suruuK