Skip to content

Commit 8259fe5

Browse files
committed
fix: solucionados algunos erroes en retorno documentValidation y ampliados los test
1 parent 73afb1a commit 8259fe5

2 files changed

Lines changed: 29 additions & 2 deletions

File tree

src/Validator.php

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -21,8 +21,8 @@ public static function documentValidation($document)
2121

2222
return [
2323
'type' => 'unknown',
24+
'value' => $document,
2425
'result' => false,
25-
'value' => 'unknown',
2626
];
2727
}
2828

tests/ValidatorTest.php

Lines changed: 28 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -12,15 +12,27 @@ public function testDniValidation()
1212
$this->assertEquals('DNI', $validator['type']);
1313
$this->assertEquals('23826295C', $validator['value']);
1414
$this->assertTrue($validator['result']);
15+
16+
$validatorFalse = Validator::documentValidation('23826295N');
17+
18+
$this->assertEquals('DNI', $validatorFalse['type']);
19+
$this->assertEquals('23826295N', $validatorFalse['value']);
20+
$this->assertFalse($validatorFalse['result']);
1521
}
1622

1723
public function testNIEValidation()
1824
{
1925
$validator = Validator::documentValidation('X8222827M');
20-
26+
2127
$this->assertEquals('NIE', $validator['type']);
2228
$this->assertEquals('X8222827M', $validator['value']);
2329
$this->assertTrue($validator['result']);
30+
31+
$validatorFalse = Validator::documentValidation('X8222827N');
32+
33+
$this->assertEquals('NIE', $validatorFalse['type']);
34+
$this->assertEquals('X8222827N', $validatorFalse['value']);
35+
$this->assertFalse($validatorFalse['result']);
2436
}
2537

2638
public function testCIFValidation()
@@ -30,19 +42,34 @@ public function testCIFValidation()
3042
$this->assertEquals('CIF', $validator['type']);
3143
$this->assertEquals('B86561412', $validator['value']);
3244
$this->assertTrue($validator['result']);
45+
46+
$validatorFalse = Validator::documentValidation('A12345678');
47+
48+
$this->assertEquals('CIF', $validatorFalse['type']);
49+
$this->assertEquals('A12345678', $validatorFalse['value']);
50+
$this->assertFalse($validatorFalse['result']);
3351
}
3452

3553
public function testIBANValidation()
3654
{
3755
$validator = Validator::ibanValidation('ES7921000813610123456789');
3856

57+
$this->assertEquals('IBAN', $validator['type']);
58+
$this->assertEquals('ES7921000813610123456789', $validator['value']);
3959
$this->assertTrue($validator['result']);
60+
61+
$validatorFalse = Validator::ibanValidation('GB94BARC20201530093459');
62+
63+
$this->assertEquals('IBAN', $validatorFalse['type']);
64+
$this->assertEquals('GB94BARC20201530093459', $validatorFalse['value']);
65+
$this->assertFalse($validatorFalse['result']);
4066
}
4167

4268
public function testInvalidFormatDocument() {
4369
$validator = Validator::documentValidation('23826295');
4470

4571
$this->assertEquals('unknown', $validator['type']);
72+
$this->assertEquals('23826295', $validator['value']);
4673
$this->assertFalse($validator['result']);
4774
}
4875
}

0 commit comments

Comments
 (0)