From 05f02699171bb717a60a0db1c8828376cb9630eb Mon Sep 17 00:00:00 2001 From: Gary Yendell Date: Fri, 23 Jan 2026 09:40:18 +0000 Subject: [PATCH] Log error when AttrR fails to validate value in update --- src/fastcs/attributes/attr_r.py | 6 +++++- 1 file changed, 5 insertions(+), 1 deletion(-) diff --git a/src/fastcs/attributes/attr_r.py b/src/fastcs/attributes/attr_r.py index 59a2f227..d84892d3 100644 --- a/src/fastcs/attributes/attr_r.py +++ b/src/fastcs/attributes/attr_r.py @@ -76,7 +76,11 @@ async def update(self, value: Any) -> None: self.log_event("Attribute set", value=repr(value), attribute=self) _previous_value = self._value - self._value = self._datatype.validate(value) + try: + self._value = self._datatype.validate(value) + except ValueError: + logger.error("Failed to validate value", value=repr(value), attribute=self) + raise self.log_event("Value validated", value=repr(self._value), attribute=self)