Small improvements

- no typeof for well-known type
- removed commented members

Author: alex-kulakov

Orm/Xtensive.Orm/Linq/ExpressionExtensions.cs

@@ -31,9 +31,6 @@ public static class ExpressionExtensions
     private static readonly Type MemoryExtensionsType = typeof(MemoryExtensions);
 
     private static readonly int[] MemoryExtensionsContainsMethodTokens;
-    //private static readonly MethodInfo ReadOnlySpanContains2;
-    //private static readonly MethodInfo ReadOnlySpanContains3;
-    //private static readonly MethodInfo SpanContains;
     private static readonly MethodInfo EnumerableContains;
 
     ///<summary>
@@ -143,15 +140,15 @@ static ExpressionExtensions()
         var parameters = method.GetParameters();
         var genericDef = parameters[0].ParameterType.GetGenericTypeDefinition();
         if (genericDef == genericReadOnlySpan) {
-          if (parameters.Length == 2 || parameters.Length==3)
+          if (parameters.Length is 2 or 3)
             candiates.Add(method.MetadataToken);
         }
         else if (genericDef == genericSpan && parameters.Length == 2) {
           candiates.Add(method.MetadataToken);
         }
       }
       MemoryExtensionsContainsMethodTokens = candiates.ToArray();
-      EnumerableContains = typeof(System.Linq.Enumerable).GetMethodEx(nameof(System.Linq.Enumerable.Contains), BindingFlags.Public | BindingFlags.Static, new string[1], new object[2]);
+      EnumerableContains = WellKnownTypes.Enumerable.GetMethodEx(nameof(System.Linq.Enumerable.Contains), BindingFlags.Public | BindingFlags.Static, new string[1], new object[2]);
     }
   }
 }

Orm/Xtensive.Orm/Orm/Linq/WellKnownMembers.cs

@@ -174,28 +174,28 @@ public static class Key
     public static class Enumerable
     {
       // Enumerable
-      public static readonly MethodInfo Select = typeof(System.Linq.Enumerable).GetMethods().First(m => m.Name == nameof(System.Linq.Enumerable.Select));
+      public static readonly MethodInfo Select = WellKnownTypes.Enumerable.GetMethods().First(m => m.Name == nameof(System.Linq.Enumerable.Select));
 
-      public static readonly MethodInfo First = typeof(System.Linq.Enumerable)
+      public static readonly MethodInfo First = WellKnownTypes.Enumerable
           .GetMethods(BindingFlags.Static | BindingFlags.Public)
           .First(m => m.Name == nameof(System.Linq.Enumerable.First) && m.GetParameters().Length == 1);
 
-      public static readonly MethodInfo FirstOrDefault = typeof(System.Linq.Enumerable)
+      public static readonly MethodInfo FirstOrDefault = WellKnownTypes.Enumerable
           .GetMethods(BindingFlags.Static | BindingFlags.Public)
           .First(m => m.Name == nameof(System.Linq.Enumerable.FirstOrDefault) && m.GetParameters().Length == 1);
 
-      public static readonly MethodInfo Single = typeof(System.Linq.Enumerable)
+      public static readonly MethodInfo Single = WellKnownTypes.Enumerable
           .GetMethods(BindingFlags.Static | BindingFlags.Public)
           .First(m => m.Name == nameof(System.Linq.Enumerable.Single) && m.GetParameters().Length == 1);
 
-      public static readonly MethodInfo SingleOrDefault = typeof(System.Linq.Enumerable)
+      public static readonly MethodInfo SingleOrDefault = WellKnownTypes.Enumerable
           .GetMethods(BindingFlags.Static | BindingFlags.Public)
           .First(m => m.Name == nameof(System.Linq.Enumerable.SingleOrDefault) && m.GetParameters().Length == 1);
 
       public static readonly Type OfTuple = WellKnownInterfaces.EnumerableOfT.CachedMakeGenericType(typeof(Xtensive.Tuples.Tuple));
-      public static readonly MethodInfo DefaultIfEmpty = typeof(System.Linq.Enumerable).GetMethods().First(m => m.Name == nameof(System.Linq.Enumerable.DefaultIfEmpty));
-      public static readonly MethodInfo Contains = GetMethod(typeof(System.Linq.Enumerable), nameof(System.Linq.Enumerable.Contains), 1, 2);
-      public static readonly MethodInfo Cast = GetMethod(typeof(System.Linq.Enumerable), nameof(System.Linq.Enumerable.Cast), 1, 1);
+      public static readonly MethodInfo DefaultIfEmpty = WellKnownTypes.Enumerable.GetMethods().First(m => m.Name == nameof(System.Linq.Enumerable.DefaultIfEmpty));
+      public static readonly MethodInfo Contains = GetMethod(WellKnownTypes.Enumerable, nameof(System.Linq.Enumerable.Contains), 1, 2);
+      public static readonly MethodInfo Cast = GetMethod(WellKnownTypes.Enumerable, nameof(System.Linq.Enumerable.Cast), 1, 1);
     }
 
     // IEntity