Merge pull request #3758 from emilioheredia-source/fix_editor_rubberband_all_containers

Extend Alt+drag rubberband to all container widgets

Author: kasemir

app/display/representation-javafx/src/main/java/org/csstudio/display/builder/representation/javafx/widgets/JFXBaseRepresentation.java

@@ -115,13 +115,12 @@ public Parent createComponents(final Parent parent) throws Exception
                     // Clicking with the primary (left) button selects the widget ..
                     if (event.isPrimaryButtonDown())
                     {
-                        // .. but ignore the group widget when Alt key is held.
-                        // This allows 'rubberbanding' within a group while Alt is held.
-                        // Without Alt, a click within a group would select-click the group,
-                        // consuming the event and preventing a any rubberband selection.
+                        // .. but ignore container widgets when Alt key is held.
+                        // This allows 'rubberbanding' within a group/tab/array/etc. while Alt is held.
+                        // Without Alt, a click within a container would select-click it,
+                        // consuming the event and preventing any rubberband selection.
                         if (event.isAltDown()  &&
-                            (model_widget instanceof GroupWidget ||
-                             model_widget instanceof TabsWidget))
+                            ChildrenProperty.getChildren(model_widget) != null)
                         {
                             // System.out.println("Ignoring click in " + model_widget);
                             return;