Add test coverage for redirect_uris in developer app responses

Agent-Logs-Url: https://github.com/AudiusProject/api/sessions/a6bf18a2-f093-43e3-b3bd-fe551aef12f8

Co-authored-by: rickyrombo <3690498+rickyrombo@users.noreply.github.com>

Author: Copilot

api/v1_developer_apps_test.go

@@ -16,6 +16,8 @@ func TestGetDeveloperAppsQueries(t *testing.T) {
 	assert.NoError(t, err)
 	assert.Len(t, developerApps, 1)
 	assert.Equal(t, "0x7d7b6b7a97d1deefe3a1ccc5a13c48e8f055e0b6", developerApps[0].Address)
+	// redirect_uris must be an empty slice (not nil) when no URIs are registered
+	assert.Equal(t, []string{}, developerApps[0].RedirectUris)
 }
 
 func TestGetDeveloperApp(t *testing.T) {
@@ -29,4 +31,6 @@ func TestGetDeveloperApp(t *testing.T) {
 	assert.True(t, strings.Contains(string(body), `"user_id":"7eP5n"`))
 	assert.True(t, strings.Contains(string(body), `"name":"cool app"`))
 	assert.Equal(t, "cool app", resp.Data.Name)
+	// redirect_uris must be an empty slice (not nil) when no URIs are registered
+	assert.Equal(t, []string{}, resp.Data.RedirectUris)
 }

api/v1_users_developer_apps_test.go

@@ -7,6 +7,7 @@ import (
 	"api.audius.co/database"
 	"api.audius.co/trashid"
 	"github.com/stretchr/testify/assert"
+	"github.com/tidwall/gjson"
 )
 
 func TestV1UsersDeveloperApps(t *testing.T) {
@@ -68,6 +69,11 @@ func TestV1UsersDeveloperApps(t *testing.T) {
 			"data.1.name":        "app_name_2",
 			"data.1.description": "app_description_2",
 		})
+		// redirect_uris must be an empty array (not null) when no URIs are registered
+		assert.True(t, gjson.GetBytes(body, "data.0.redirect_uris").IsArray())
+		assert.Equal(t, 0, len(gjson.GetBytes(body, "data.0.redirect_uris").Array()))
+		assert.True(t, gjson.GetBytes(body, "data.1.redirect_uris").IsArray())
+		assert.Equal(t, 0, len(gjson.GetBytes(body, "data.1.redirect_uris").Array()))
 	}
 
 	{
@@ -125,3 +131,57 @@ func TestV1UsersDeveloperAppsIncludeMetrics(t *testing.T) {
 		"data.0.api_access_keys.#":      0,
 	})
 }
+
+// TestV1UsersDeveloperAppsRedirectUrisOrdering verifies that redirect_uris are returned
+// in deterministic order (by oauth_redirect_uris.id) rather than alphabetically,
+// and that apps without registered URIs return an empty array rather than null.
+func TestV1UsersDeveloperAppsRedirectUrisOrdering(t *testing.T) {
+	app := emptyTestApp(t)
+
+	fixtures := database.FixtureMap{
+		"users": []map[string]any{
+			{"user_id": 1, "handle": "user1"},
+		},
+		"developer_apps": []map[string]any{
+			{
+				"address":    "app_address_1",
+				"user_id":    1,
+				"name":       "app_name_1",
+				"is_current": true,
+				"is_delete":  false,
+				"created_at": time.Now(),
+			},
+			{
+				"address":    "app_address_2",
+				"user_id":    1,
+				"name":       "app_name_2",
+				"is_current": true,
+				"is_delete":  false,
+				"created_at": time.Now().Add(-time.Second),
+			},
+		},
+		// Insert z before a: if ordering were alphabetical, a would come first.
+		// With id ordering, z comes first because it was inserted with a lower id.
+		"oauth_redirect_uris": []map[string]any{
+			{"client_id": "app_address_1", "redirect_uri": "https://z.example.com/callback"},
+			{"client_id": "app_address_1", "redirect_uri": "https://a.example.com/callback"},
+		},
+	}
+
+	database.Seed(app.pool.Replicas[0], fixtures)
+
+	status, body := testGet(t, app, "/v1/users/"+trashid.MustEncodeHashID(1)+"/developer-apps")
+	assert.Equal(t, 200, status)
+	// app_address_1 has 2 redirect URIs; z was inserted first (lower id) so it must come first
+	jsonAssert(t, body, map[string]any{
+		"data.#":                  2,
+		"data.0.address":          "app_address_1",
+		"data.0.redirect_uris.#":  2,
+		"data.0.redirect_uris.0":  "https://z.example.com/callback",
+		"data.0.redirect_uris.1":  "https://a.example.com/callback",
+		"data.1.address":          "app_address_2",
+	})
+	// app_address_2 has no redirect URIs; must be an empty array, not null
+	assert.True(t, gjson.GetBytes(body, "data.1.redirect_uris").IsArray())
+	assert.Equal(t, 0, len(gjson.GetBytes(body, "data.1.redirect_uris").Array()))
+}

go.mod

@@ -21,6 +21,7 @@ require (
 	github.com/gofiber/contrib/fiberzap/v2 v2.1.5
 	github.com/gofiber/contrib/websocket v1.3.4
 	github.com/gofiber/fiber/v2 v2.52.9
+	github.com/google/uuid v1.6.0
 	github.com/jackc/pgerrcode v0.0.0-20240316143900-6e2875d9b438
 	github.com/jackc/pgx/v5 v5.7.4
 	github.com/jackc/pgxlisten v0.0.0-20241106001234-1d6f6656415c
@@ -122,7 +123,6 @@ require (
 	github.com/google/go-cmp v0.7.0 // indirect
 	github.com/google/go-querystring v1.1.0 // indirect
 	github.com/google/orderedcode v0.0.1 // indirect
-	github.com/google/uuid v1.6.0 // indirect
 	github.com/gorilla/rpc v1.2.0 // indirect
 	github.com/gorilla/websocket v1.5.3 // indirect
 	github.com/gowebpki/jcs v1.0.0 // indirect