Skip to content

Commit b2d3f51

Browse files
committed
Replace magic number with constant
1 parent 94b43f6 commit b2d3f51

File tree

1 file changed

+36
-34
lines changed

1 file changed

+36
-34
lines changed

PWGHF/TableProducer/treeCreatorXicToXiPiPi.cxx

Lines changed: 36 additions & 34 deletions
Original file line numberDiff line numberDiff line change
@@ -78,9 +78,9 @@ DECLARE_SOA_COLUMN(PtPi1, ptPi1, float);
7878
DECLARE_SOA_COLUMN(ImpactParameterPi1, impactParameterPi1, float); //! Normalised impact parameter of Pi1 (prong2)
7979
DECLARE_SOA_COLUMN(ImpactParameterNormalisedPi1, impactParameterNormalisedPi1, float); //! Normalised impact parameter of Pi1 (prong2)
8080
DECLARE_SOA_COLUMN(MaxNormalisedDeltaIP, maxNormalisedDeltaIP, float); //! Maximum normalized difference between measured and expected impact parameter of candidate prongs
81-
DECLARE_SOA_COLUMN(MlScoreBkg, mlScoreBkg, float); //! ML score for background class
82-
DECLARE_SOA_COLUMN(MlScorePrompt, mlScorePrompt, float); //! ML score for prompt signal class
83-
DECLARE_SOA_COLUMN(MlScoreNonPrompt, mlScoreNonPrompt, float); //! ML score for non-prompt signal class (3-class model only, -1 otherwise)
81+
DECLARE_SOA_COLUMN(MlScoreBkg, mlScoreBkg, float); //! ML score for background class
82+
DECLARE_SOA_COLUMN(MlScorePrompt, mlScorePrompt, float); //! ML score for prompt signal class
83+
DECLARE_SOA_COLUMN(MlScoreNonPrompt, mlScoreNonPrompt, float); //! ML score for non-prompt signal class (3-class model only, -1 otherwise)
8484
} // namespace full
8585

8686
DECLARE_SOA_TABLE(HfCandXicToXiPiPiLites, "AOD", "HFXICXI2PILITE",
@@ -391,6 +391,8 @@ struct HfTreeCreatorXicToXiPiPi {
391391
Configurable<float> downSampleBkgFactor{"downSampleBkgFactor", 1., "Fraction of background candidates to keep for ML trainings"};
392392
Configurable<float> ptMaxForDownSample{"ptMaxForDownSample", 10., "Maximum pt for the application of the downsampling factor"};
393393

394+
static constexpr int kNumBinaryClasses = 2;
395+
394396
using SelectedCandidates = soa::Filtered<soa::Join<aod::HfCandXic, aod::HfSelXicToXiPiPi>>;
395397
using SelectedCandidatesKf = soa::Filtered<soa::Join<aod::HfCandXic, aod::HfCandXicKF, aod::HfSelXicToXiPiPi>>;
396398
using SelectedCandidatesML = soa::Filtered<soa::Join<aod::HfCandXic, aod::HfMlXicToXiPiPi, aod::HfSelXicToXiPiPi>>;
@@ -410,7 +412,7 @@ struct HfTreeCreatorXicToXiPiPi {
410412
void init(InitContext const&)
411413
{
412414
std::array<bool, 6> doprocess{doprocessData, doprocessDataKf, doprocessDataWithML, doprocessMc, doprocessMcKf, doprocessMcWithML};
413-
if (std::accumulate(doprocess.begin(), doprocess.end(),0) != 1) {
415+
if (std::accumulate(doprocess.begin(), doprocess.end(), 0) != 1) {
414416
LOGP(fatal, "Only one process function can be enabled at a time.");
415417
}
416418
}
@@ -683,40 +685,40 @@ struct HfTreeCreatorXicToXiPiPi {
683685
if (scoreSize > 0) {
684686
mlScoreBkg = candidate.mlProbXicToXiPiPi()[0];
685687
mlScorePrompt = candidate.mlProbXicToXiPiPi()[1];
686-
if (scoreSize > 2) {
688+
if (scoreSize > kNumBinaryClasses) {
687689
mlScoreNonPrompt = candidate.mlProbXicToXiPiPi()[2];
688690
}
689691
}
690692
rowCandidateLiteMl(
691-
particleFlag,
692-
originMc,
693-
candidate.isSelXicToXiPiPi(),
694-
candidate.y(o2::constants::physics::MassXiCPlus),
695-
candidate.eta(),
696-
candidate.phi(),
697-
candidate.p(),
698-
candidate.pt(),
699-
candidate.invMassXicPlus(),
700-
candidate.invMassXi(),
701-
candidate.invMassLambda(),
702-
candidate.decayLength(),
703-
candidate.decayLengthXY(),
704-
candidate.cpa(),
705-
candidate.cpaXY(),
706-
candidate.cpaXi(),
707-
candidate.cpaXYXi(),
708-
candidate.cpaLambda(),
709-
candidate.cpaXYLambda(),
710-
candidate.impactParameter0(),
711-
candidate.impactParameterNormalised0(),
712-
candidate.impactParameter1(),
713-
candidate.impactParameterNormalised1(),
714-
candidate.impactParameter2(),
715-
candidate.impactParameterNormalised2(),
716-
candidate.maxNormalisedDeltaIP(),
717-
mlScoreBkg,
718-
mlScorePrompt,
719-
mlScoreNonPrompt);
693+
particleFlag,
694+
originMc,
695+
candidate.isSelXicToXiPiPi(),
696+
candidate.y(o2::constants::physics::MassXiCPlus),
697+
candidate.eta(),
698+
candidate.phi(),
699+
candidate.p(),
700+
candidate.pt(),
701+
candidate.invMassXicPlus(),
702+
candidate.invMassXi(),
703+
candidate.invMassLambda(),
704+
candidate.decayLength(),
705+
candidate.decayLengthXY(),
706+
candidate.cpa(),
707+
candidate.cpaXY(),
708+
candidate.cpaXi(),
709+
candidate.cpaXYXi(),
710+
candidate.cpaLambda(),
711+
candidate.cpaXYLambda(),
712+
candidate.impactParameter0(),
713+
candidate.impactParameterNormalised0(),
714+
candidate.impactParameter1(),
715+
candidate.impactParameterNormalised1(),
716+
candidate.impactParameter2(),
717+
candidate.impactParameterNormalised2(),
718+
candidate.maxNormalisedDeltaIP(),
719+
mlScoreBkg,
720+
mlScorePrompt,
721+
mlScoreNonPrompt);
720722
}
721723
}
722724

0 commit comments

Comments
 (0)