From 97f69d2ee2b43b3146d2ba7af5f812b0d38bb13a Mon Sep 17 00:00:00 2001 From: GuustMetz Date: Fri, 27 Mar 2026 16:14:41 +0100 Subject: [PATCH 1/4] doing thething --- test/public/runs/runsPerLhcPeriod.overview.test.js | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/test/public/runs/runsPerLhcPeriod.overview.test.js b/test/public/runs/runsPerLhcPeriod.overview.test.js index 273baca07d..27261819d2 100644 --- a/test/public/runs/runsPerLhcPeriod.overview.test.js +++ b/test/public/runs/runsPerLhcPeriod.overview.test.js @@ -217,8 +217,8 @@ module.exports = () => { await waitForButtonToBecomeActive(page, EXPORT_RUNS_TRIGGER_SELECTOR); // First export await pressElement(page, EXPORT_RUNS_TRIGGER_SELECTOR, true); - await page.waitForSelector('select.form-control', { timeout: 200 }); - await page.waitForSelector('option[value=runNumber]', { timeout: 200 }); + await page.waitForSelector('select.form-control'); + await page.waitForSelector('option[value=runNumber]'); await page.select('select.form-control', 'runQuality', 'runNumber', 'definition', 'lhcPeriod'); await expectInnerText(page, '#send:enabled', 'Export'); From a05551346838a35856e37017d9b23011583f9478 Mon Sep 17 00:00:00 2001 From: GuustMetz Date: Fri, 27 Mar 2026 16:33:02 +0100 Subject: [PATCH 2/4] stealth fix a test --- test/public/runs/overview.test.js | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/test/public/runs/overview.test.js b/test/public/runs/overview.test.js index 3b7cb97da4..d849cb686f 100644 --- a/test/public/runs/overview.test.js +++ b/test/public/runs/overview.test.js @@ -954,9 +954,9 @@ module.exports = () => { await page.waitForSelector(badFilterSelector); await page.$eval(badFilterSelector, (element) => element.click()); await page.waitForSelector('tbody tr:nth-child(2)'); - await page.waitForSelector(EXPORT_RUNS_TRIGGER_SELECTOR); ///// Download + await waitForButtonToBecomeActive(page, EXPORT_RUNS_TRIGGER_SELECTOR); await page.$eval(EXPORT_RUNS_TRIGGER_SELECTOR, (button) => button.click()); await page.waitForSelector('#export-data-modal', { timeout: 5000 }); From 5239e22ee499bc4c7281eb8424095d8271bcd37e Mon Sep 17 00:00:00 2001 From: GuustMetz Date: Sun, 29 Mar 2026 19:40:54 +0200 Subject: [PATCH 3/4] properly set the rowcount before exporting --- test/public/runs/runsPerLhcPeriod.overview.test.js | 9 ++------- 1 file changed, 2 insertions(+), 7 deletions(-) diff --git a/test/public/runs/runsPerLhcPeriod.overview.test.js b/test/public/runs/runsPerLhcPeriod.overview.test.js index 27261819d2..77d1ec4a24 100644 --- a/test/public/runs/runsPerLhcPeriod.overview.test.js +++ b/test/public/runs/runsPerLhcPeriod.overview.test.js @@ -201,18 +201,13 @@ module.exports = () => { // Revert changes for next test await page.evaluate(() => { // eslint-disable-next-line no-undef - model.runs.perLhcPeriodOverviewModel.pagination.itemsPerPage = 10; + model.runs.perLhcPeriodOverviewModel.pagination.itemsPerPage = 2; }); - await waitForTableLength(page, 4); + await waitForTableLength(page, 2); }); it('should successfully export all runs per lhc Period', async () => { - await page.evaluate(() => { - // eslint-disable-next-line no-undef - model.runs.perLhcPeriodOverviewModel.pagination.itemsPerPage = 2; - }); - const targetFileName = 'data.json'; await waitForButtonToBecomeActive(page, EXPORT_RUNS_TRIGGER_SELECTOR); // First export From 23adc990495b17f02977f9ceb7d00fc7f455e4ad Mon Sep 17 00:00:00 2001 From: GuustMetz Date: Sun, 29 Mar 2026 19:41:21 +0200 Subject: [PATCH 4/4] add loading symbol whilst waiting for name --- .../views/Runs/RunPerPeriod/RunsPerLhcPeriodOverviewPage.js | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/lib/public/views/Runs/RunPerPeriod/RunsPerLhcPeriodOverviewPage.js b/lib/public/views/Runs/RunPerPeriod/RunsPerLhcPeriodOverviewPage.js index 2aaee87d58..f4e0895e4c 100644 --- a/lib/public/views/Runs/RunPerPeriod/RunsPerLhcPeriodOverviewPage.js +++ b/lib/public/views/Runs/RunPerPeriod/RunsPerLhcPeriodOverviewPage.js @@ -102,14 +102,14 @@ export const RunsPerLhcPeriodOverviewPage = ({ runs: { perLhcPeriodOverviewModel const lhcPeriodName = remoteLhcPeriodStatistics?.match({ Success: (lhcPeriodStatistics) => lhcPeriodStatistics.lhcPeriod.name, - Other: () => '', + Other: () => spinner({ size: 1, absolute: false }), }); return [ h('.flex-row.justify-between.items-center.g2', [ filtersPanelPopover(perLhcPeriodOverviewModel, activeColumns, { profile: 'runsPerLhcPeriod' }), h('.pl2#runOverviewFilter', runNumbersFilter(perLhcPeriodOverviewModel.filteringModel.get('runNumbers'))), - h('h2', ['Good physics runs of ', lhcPeriodName ?? spinner({ size: 1, absolute: false })]), + h('h2', ['Good physics runs of ', lhcPeriodName]), mcReproducibleAsNotBadToggle( mcReproducibleAsNotBad, () => perLhcPeriodOverviewModel.setMcReproducibleAsNotBad(!mcReproducibleAsNotBad),