Some AMD modules fail to build on the latest OpenBMC

[illiav-j]

Hello

I was trying to bring the AMD modules in recipes-amd to the latest OpenBMC master branch.

Here is the list of issues and necessary fixes:

• Return value of i2c_smbus_read… is checked incorrectly in vr-update: Fix i2c_smbus_read_i2c_block_data return value check vr-firmware-update#19
• Uninitialised read in amd-ras: Fix uninitialised read in apmlActiveMonitor amd-bmc-ras#91
• Return value of popen is checked incorrectly:
  • cpu-info: Fix popen return value check bmc-cpuinfo#11
  • power-capping: Fix popen return value check amd-power-cap#33
• Switch to C++20 for modules using sdbusplus. sdbusplus headers use newer C++ features that fail to compile with older C++ standard versions.
  • amd-ras
  • cpu-info
  • power-capping
  • vr-update
• Use of removed phosphor-mapper.bbclass in amd-ras.bb: fix
• libmctp-intel fails to compile a test: fix
• Remove esmi_mailbox_nda.h include. It is not present in the public repo but everything compiled fine without it:
  • amd-ras
  • cpu-info
• amd-apml recipe references non-public https://github.com/amd/apml_library. Change to https://github.com/amd/esmi_oob_library
• The layer is not compatible with the never Yocto release: illiav-j@0204c54

Other changes:

• usb-network non-declared dependency: fix
• UB in power-capping: potential fix
• Cloning from GitHub using SSH protocol requires authentication. Changed the recipes to use HTTPS protocol: illiav-j@e151e40 It should also be more secure than SSH's Trust On First Use model.
• Not specifying SRCREV may cause breakages when the source is updated in non-backwards compatible manner. Specified SRCREV: illiav-j@e151e40

Hopefully this will be useful when updating to the latest OpenBMC. The first four pull requests should also be good for the current version.