static update data by id#21
Open
goigarg wants to merge 8 commits into
Open
Conversation
amostajo
requested changes
May 2, 2022
| * @param array $data | ||
| * @return bool | ||
| */ | ||
| public static function updateData($id, $data) |
Collaborator
There was a problem hiding this comment.
We need to look for a more generic method name. Maybe ::modify(). Also, needs to follow comments standard, same as the other methods. Unit testing is missing.
| /** | ||
| * Destroy Model statically | ||
| */ | ||
| public static function destroy($id) |
Collaborator
There was a problem hiding this comment.
Missin comments standard, same as the other methods and unit testing.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.